Repository navigation
Fix x and y axis naming in dendrogram trace - #4411
Merged
Merged
Conversation
alexcjohnson
approved these changes
Nov 3, 2023
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Very nice, thanks. I do think we could include a changelog entry if you'd like to add one, but you're right we can do without extra tests.
Brainor
commented
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a very simple bug, so I don't think it needs any additional tests or even deserves a changelog entry 😢
plotly.py/packages/python/plotly/plotly/figure_factory/_dendrogram.py
Lines 380 to 391 in 69c20f7
If
x_indexis int from line 381, line 390 will causeTypeError: can only concatenate str (not "int") to strfrom concatenating str("x") and int(3).The error could accur when someone tries to create a dendrogram plot in a subplot in which the
xaxis's name is notxaxisbutxaxis3.plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.