Skip to content

Update box-plots.md - #4282

Merged
LiamConnors merged 2 commits into
plotly:doc-prodfrom
patelvyom:patch-1
Sep 19, 2024
Merged

LiamConnors merged 2 commits into
plotly:doc-prodfrom
patelvyom:patch-1

Conversation

@patelvyom

Copy link
Copy Markdown
Contributor
  • There is no need for passing dummy variable y when stats have already been computed
  • upperfence values don't match the resulting figure.
  • It could be simplified even further by getting rid of the extra call to add_trace but I've kept it to follow the documentation styling.
  • It might be worth it to separate the example in two cases: (i) with only q1, median, q3 provided, (ii) with all values provided.

- There is no need for passing dummy variable `y` when stats have already been computed
- `upperfence` values don't match the resulting figure.
- It could be simplified even further by getting rid of the extra call to `add_trace` but I've kept it to follow the documentation styling.
- It might be worth it to separate the example in two cases: (i) with only `q1`, `median`, `q3` provided, (ii) with all values provided.
@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution documentation written for humans labels Aug 12, 2024
@LiamConnors
LiamConnors self-requested a review September 19, 2024 13:49

@LiamConnors LiamConnors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @patelvyom. Sorry for the delay in getting this merged.

@LiamConnors
LiamConnors merged commit c105f45 into plotly:doc-prod Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution documentation written for humans feature something new P2 considered for next cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants