Skip to content

Port cufflinks - #2325

Merged
nicolaskruchten merged 5 commits into
doc-prodfrom
cufflinks
Mar 27, 2020
Merged

Port cufflinks#2325
nicolaskruchten merged 5 commits into
doc-prodfrom
cufflinks

Conversation

@nicolaskruchten

Copy link
Copy Markdown
Contributor

@emmanuelle

Copy link
Copy Markdown
Contributor

CI fails with

Checking... are there posts with order > 5 and 'page_type: example_index'?
NOT PASSED!

for the new tutorial

@emmanuelle

Copy link
Copy Markdown
Contributor

did you merge my recent chart-studio fixes and is it something different for the 2.7 CI failure?

@nicolaskruchten

Copy link
Copy Markdown
Contributor Author

This is in doc-prod so your fixes have not been applied yet, no, not until the next release.

Comment thread doc/python/cufflinks.md Outdated
Comment thread doc/python/cufflinks.md Outdated
@emmanuelle

Copy link
Copy Markdown
Contributor

Looks good! It could be nice to add an example calling fig.update_layout or update_traces after calling iplot but this can be done later so 💃

nicolaskruchten and others added 2 commits March 27, 2020 12:14
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
@nicolaskruchten
nicolaskruchten merged commit 1947798 into doc-prod Mar 27, 2020
@nicolaskruchten

Copy link
Copy Markdown
Contributor Author

Thanks!

@nicolaskruchten
nicolaskruchten deleted the cufflinks branch June 19, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants