Skip to content

Codegen seems broken! #4870

Description

@archmoj

After PRs merged today it appears the codegen is not producing the correct outputs.

In the morning I was able to generate correct plotly.py code after 5497d17

But now I can not locate this file: packages/javascript/jupyterlab-plotly/package.json i.e. to control the version of plotly.js.

Activity

  1. marthacryan commented on Nov 13, 2024

    @marthacryan
    Contributor

    The new source of the plotly.js version is packages/python/plotly/js/package.json (I know this seems odd to be under packages/python but we're planning to reorganize directories soon to change packages/python to just packages). This is documented in contributing.md.

    There are a few codegen commands in setup.py. Which one are you using?

  2. archmoj commented on Nov 13, 2024

    @archmoj
    ContributorAuthor

    @marthacryan I am using these steps:
    https://github.com/plotly/plotly.py/blob/master/contributing.md#update-to-a-new-version-of-plotlyjs

    $ cd packages/python/plotly
    $ python setup.py updateplotlyjs
    
  3. archmoj commented on Nov 13, 2024

    @archmoj
    ContributorAuthor

    As a result the traces and attributes we deleted in plotly.js v3.0.0-rc.0 are back e.g.

    	plotly/graph_objs/_heatmapgl.py
    	plotly/graph_objs/_pointcloud.py
    	plotly/graph_objs/heatmapgl/
    	plotly/graph_objs/layout/template/data/_heatmapgl.py
    	plotly/graph_objs/layout/template/data/_pointcloud.py
    	plotly/graph_objs/pointcloud/
    	plotly/validators/_heatmapgl.py
    	plotly/validators/_pointcloud.py
    	plotly/validators/heatmapgl/
    	plotly/validators/layout/template/data/_heatmapgl.py
    	plotly/validators/layout/template/data/_pointcloud.py
    	plotly/validators/pointcloud/
    
  4. archmoj commented on Nov 13, 2024

    @archmoj
    ContributorAuthor

    Resolved by #4871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions