Skip to content

Drop deprecated pointcloud and heatmapgl traces and gl2d subplots - #7213

Merged
archmoj merged 23 commits into
masterfrom
drop-gl2d
Oct 8, 2024
Merged

archmoj merged 23 commits into
masterfrom
drop-gl2d

Conversation

@archmoj

@archmoj archmoj commented Oct 7, 2024 •

Copy link
Copy Markdown
Contributor

Closes #7176 and closes #7175.
Users could use scattergl and heatmap traces instead to draw similar graphs.
@plotly/plotly_js

@emilykl

emilykl commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

@archmoj Are scattergl and image direct drop-in replacements for pointcloud and heatmapgl? Or are some of the props different?

Is there a replacement for gl2d subplots?

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @archmoj , I don't see any red flags as long as tests are passing

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 8, 2024
@archmoj

archmoj commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

@archmoj Are scattergl and image direct drop-in replacements for pointcloud and heatmapgl? Or are some of the props different?

Is there a replacement for gl2d subplots?

@emilykl No they are not direct drop-in replacements.
gl2d subplots are only only used for these these two traces and other 2-D WebGL-based traces e.g. scattergl, splom and parcoords do not use it.

@archmoj

archmoj commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

@alexcjohnson Would you accept these changes?

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding it’s actually heatmap that replaces heatmapgl, ie just “downgrading” to the SVG version gives you the same or better performance with many more features. pointcloud is different, scattergl is not a drop-in replacement, but it solves the same use cases and many more.

this is great, I highly support these changes 💃

@archmoj
archmoj merged commit 2c51844 into master Oct 8, 2024
@archmoj
archmoj deleted the drop-gl2d branch October 8, 2024 19:51
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull request Mar 31, 2025
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull request Mar 31, 2025
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull request Apr 1, 2025
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new P1 needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop pointcloud for Plotly.js v3 Drop heatmapgl for Plotly.js v3

4 participants