Skip to content

Bump has-hover - #1890

Merged
dy merged 1 commit into
masterfrom
bump-has-hover
Jul 19, 2017
Merged

Bump has-hover#1890
dy merged 1 commit into
masterfrom
bump-has-hover

Conversation

@dy

@dy dy commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

Enable better hover detection

resolves #1889

@etpinard

@etpinard etpinard added status: reviewable bug something broken labels Jul 18, 2017
@etpinard

etpinard commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

@dfcreative Thanks for fix! 🎉

Can you make a standalone page with this patch so that we can test it on browserstack?

@rreusser

Copy link
Copy Markdown
Contributor

At risk of interfering, does this work? https://codepen.io/rsreusser/full/qjGvxN/

@dy

dy commented Jul 18, 2017

Copy link
Copy Markdown
Contributor Author

@rreusser yep.
@etpinard here is the standalone page https://dfcreative.github.io/plotly-contrib/has-hover

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Can someone with an android phone try this out? It fails for me for Chrome on the android devices I tried on browserstack, but works on my wife's google pixel. Everywhere else I've tried it seems to work great.

@etpinard etpinard added this to the 1.29.0 milestone Jul 18, 2017
@etpinard

Copy link
Copy Markdown
Contributor

hasHover works for me on Android Chrome 59.0.3071.125

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Alright - I'm willing to assume there's something funny going on with browserstack in that regard, since it seems to work on all the devices we can actually get our hands on. Thanks @rreusser and @dfcreative ! 💃

@etpinard

Copy link
Copy Markdown
Contributor

@dfcreative by the way 💃 means: you're free to merge. We let plotly dev merge their own PRs. That means more commits on master for you 🏁

@dy
dy merged commit 97d08c8 into master Jul 19, 2017
@dy
dy deleted the bump-has-hover branch July 19, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modebar always visible in FF and IE

4 participants