Repository navigation
Prune unsupported global-level trace attributes #3058
Description
There are a bunch of attributes that we insert in the schema, and largely include in _fullData for all trace types. But many trace types don't support all of these attributes. As a simple workaround in @jonmmease's parcats PR, 273d2d0 (following @etpinard's suggestion #2963 (comment)) hides a the ones parcats doesn't use from the schema, but they will still show up in _fullData.
As I said in #2963 (comment):
There's a module
categories: ['noOpacity']which prevents coercingopacity(so it's not infullData, which is important for the editor) but does not take it out of the schema (and anyway only handlesopacity). @etpinard 's solution would fix the schema but notfullData. Sounds like what we really want is something like:module.omitGlobalAttrs: ['selectedpoints', 'hoverlabel', 'opacity', 'ids', 'customdata']that would do both.
There are probably quite a few other traces that omit some of these - in fact, probably everything that sets
traceOut._length = nullhas no use forselectedpoints,ids, andcustomdata...
And @etpinard responded #2963 (comment):
Good point here. But I think for this PR my suggestion in #2963 (comment) will be good enough. The react-chart-editor (aka RCE) doesn't know how to handle traces with
dimensionsyet, so having a few extra keys in fullData won't affect anyone at this stage. But yeah, once merged we should open a new issue (similar to #2834 and #2908) about this.
So here's that issue :)
Activity
alexcjohnson commentedon Oct 11, 2018
There's a related issue with the way we merge base and module attributes in the schema: sometimes
extendDeepAllgoes too far, as in:where the second
"name"came from the base["x", "y", "z", "text", "name"]getting added to a length-4 override in the module. We should really do a more manual crawl, only adding base attributes if they haven't been overridden in the module.Anyway a lot of modules that have no
"z"inappropriately inherit it as well, this should really perhaps always be handled at the module level.etpinard commentedon Oct 30, 2018
After @antoinerg 's #3158
hoverinfoflags are now extended properly in trace attribute modulehoverlabelis now omitted in attributes and notcoercedfor traces that don't support itNow, me and @alexcjohnson disagree on what to do with
idsandcustomdata. We'll leave this issue open until we reach a consensus.antoinerg commentedon Oct 31, 2018
After @antoinerg's #3158
transformswas removed fromcarpet,cone,contourcarpet,mesh3d,heatmap,parcoords,pointcloud,sankey,streamtube,surfaceandtableetpinard commentedon Apr 5, 2019
showLegendcategory should not haveshowlegend,legendgroupin their schemafix #3058 - prune-out base attrs based on module categories