This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Just changes in `/src` from branch forbid-popup-windows - #72

Merged

etpinard merged 8 commits into

just-changes-in-src-from-forbid-popup-windows

Apr 16, 2018

Commits on Apr 14, 2018

https://github.com/plotly/image-exporter/issues/65#issuecomment-380532988
JamesCropcho
committed
5debb1e
"Probably best to set show: opts.debug for debugging purposes."
JamesCropcho
committed
0a634d3
"shall we add show: false to the server too?"
JamesCropcho
committed
7a6586e
"there's a few more createBrowserWindow calls" "Moreover, here too we should set show: opts.debug."
JamesCropcho
committed
5616ec1
`remote.createBrowserWindow`'s `show` parameter appears to treat `undefined` as true. This commit performs like casting to a Boolean.
JamesCropcho
committed
de73f03
"On Windows and Linux, setting this to true should keep the electron window from displaying in the taskbar, which I believe to be desirable for making image export a seamless experience for Windows…
JamesCropcho
committed
9af7553
"To hide the electron icon from the dock on OS X it is recommended (electron-userland/electron-builder#1456) to add "extendInfo": {"LSUIElement": 1} to the top-level mac configuration settings"
JamesCropcho
committed
f81ff05

Commits on Apr 16, 2018

Manual reverting of changes in package.json from previous commits on `forbid-popup-windows`
JamesCropcho
committed
3757c97