Repository navigation
Unable to get parquets-lite library to work for dash-renderer #1806
Description
Context
As a part of this PR, the dash renderer client now needs to decode parquet data from layout to create pandas.DataFrame-like objects or records for DataTable React component.
Wanna take a look?
Since it's a part of Two-way serialization PR, you need to check out this branch.
Once checked out the repo/branch,
- Change this line like below.
return DataFrameSerializer.serialize(value, engine="fastparquet")- Change another line like below again.
return DataFrameSerializer.serialize(propValue, engine="fastparquet")npm run build- Run this Dash app code
- Open the browser to see the page rendered
Expected Behavior
Supposed to see 3 tables on the rendered page, without any rendering or console issues.
Actual Behavior
You'll see the rendering failed and some console logs like invalid parquet version or errors thrown out from parquets-lite which is added here
Some more context for in-Slack engineers 🦸
Metadata
Metadata
Assignees
Labels
No labels
Activity
nicholas-esterer commentedon Oct 22, 2021
I have a fix of the parquet decoding but it seems there are still errors when encoding the parquet. Anyhow, how can I open a PR into this branch? @workaholicpanda you are in a different organization as you have a fork of dash, but probably we sure eventually merge my branch into yours on your fork before merging into plotly/dash
My branch:
https://github.com/plotly/dash/tree/two-way-serialization-fastparquet
workaholicAB commentedon Oct 22, 2021
@nicholas-esterer Thanks so much for getting this fixed. I'm testing it right now.
Are you okay if I can cherry pick your commit to my fork then get everything merged in a single PR?
nicholas-esterer commentedon Oct 22, 2021
Yep no problem!