Skip to content

Rename id argument of callback! to params to match Dash convention  #32

Description

@rpkyle

Following discussion offline with @alexcjohnson, we should rename the id argument of callback! to params, which aligns with current Dash convention. We already use id as a property within Dash components, so this usage is potentially confusing as-is.

This is a breaking change in the Dash.jl API, and we should probably make the modification sooner rather than later.

function callback!(func::Function, app::DashApp, id::CallbackId)

This likely implies that we should consider renaming CallbackId to Params (or SetParams or Setparms or setparms) and callid_str to params_str (and, callid also):

struct CallbackId

macro callid_str(s)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priorityDash.jl tasks that should be completed prior to non-priority items

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions