Fix translation keys that do not resolve - #354
Merged
Cannonb4ll merged 1 commit intoSep 12, 2026
Merged
Conversation
- auth.verify-new-success had a trailing period inside the key, so the verification resend banner showed the raw key - BoardResource used resources.user.created-at instead of resources.created-at - ItemResource used resources.item.github-issue-create, which does not exist; use resources.item.github.create Add a test asserting that every literal translation key used in app/ and resources/views exists in the English translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few
trans()calls reference keys that don't exist, so the raw key is shown to users instead of the translated text.Fixes
auth/verify-email.blade.php,auth/verify.blade.phpauth.verify-new-success.(trailing period inside the key)auth.verify-new-successBoardResourcecreated at columnresources.user.created-atresources.created-at(as used by every other resource)ItemResourceGitHub issue modal submit buttonresources.item.github-issue-createresources.item.github.createThe first one is the most visible: after requesting a new verification email, the success banner reads
auth.verify-new-success.instead of "A fresh verification link has been sent to your email address."Regression test
Adds
tests/Feature/TranslationKeysTest.php, which scansapp/andresources/viewsfor translation keys passed as a string literal to__(),trans(),trans_choice()or@lang, and asserts each one exists in the English translations. Dynamically built keys (e.g.'general.' . $type) are skipped. The test fails onmainand passes with these fixes.