Correctly exclude arcat when it's in a non-standard location with an in-repo interpreter - #330
Merged
Merged
Conversation
…in-repo interpreter
peterebden
requested review from
SpangleLabs,
chrisnovakovic and
toastwaffle
September 23, 2026 17:16
toastwaffle
approved these changes
Sep 23, 2026
Member
Author
|
Oh yes - you also have to be using remote execution, otherwise tools aren't in the working directory. |
chrisnovakovic
approved these changes
Sep 23, 2026
SpangleLabs
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this is kind of subtle. When we hit this particular branch of code, we pass
--exclude_toolsbut that overrides the implicit default of$TOOLSthat usually excludes itself. Make sure arcat is still in this list. If not it can end up packaging itself which is generally undesirable.