Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
GLFW_EXPOSE_NATIVE_XCB provides glfwGetXCBConnection/VisualID/Window without including Xlib, so vulkan_objects_glfw_xcb and glfw_xcb_hack.cpp are removed. vko::glfw:: keeps using-declarations for existing callers. GLFW's getter returns NULL when X11-xcb is not loaded, e.g. with the GLFW_X11_XCB_VULKAN_SURFACE init hint off. Presentation support now checks it instead of passing NULL to the driver (llvmpipe segfaulted), falling back to Xlib when enabled. vulkan_objects no longer links X11/XCB libraries for XCB. Consumers that call Xlib themselves must link it. The Xlib path now links X11::X11, which it previously got from the XCB link. errorToString gains the error codes added in GLFW 3.4. Requires a GLFW with the XCB getters (glfw/glfw#2906). No release has them yet, so VULKAN_OBJECTS_GLFW_TAG must be bumped once one does.
pknowles
marked this pull request as draft
September 25, 2026 22:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.