refactor: remove duplicate runtime logic and test scaffolding - #9939
Closed
maria-rcks wants to merge 3 commits into
Closed
maria-rcks wants to merge 3 commits into
maria-rcks wants to merge 3 commits into
Conversation
github-actions
Bot
added
vouch:trusted
github-actions
Bot
added
size:XXL
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
maria-rcks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated activity parsers, orchestration event construction, SQL projections, IPC types, and test setup made equivalent behavior expensive to maintain. This cleanup removes 3,420 net lines across 51 files by sharing existing logic, deriving types from schemas, consolidating fixtures and table-driven cases, and deleting unused helpers while preserving platform-specific behavior.
Validation: 1,124 unique tests across 34 existing suites passed, along with nine affected workspace typechecks and changed-file formatting/lint (19 existing warnings). All 7,776 compared dev environment combinations matched; the upstream checkpoint conflict was resolved preserving its new interrupted-turn coverage, and all 35 reducer tests passed afterward. Real-app checks covered project-source labels, GitHub input, Git URL destination confirmation/cancel, and a draft thread in light/dark themes; native clients and live provider turns were not manually exercised.
Draft requested by Maria. Keep DO NOT MERGE. GitHub CI passed Check, Test, all three server shards, Rust, Release Smoke, and native fingerprint checks; the Effect Service Conventions bot remains queued. Two independent available-runtime reviewers found no correctness regressions on ab406db; the green-pr skill's required gpt-6-astra reviewers are unavailable, so formal readiness certification remains blocked. The sole SQL review finding was checked against both commits, disproved by the qualified query and 22 passing projection tests, and resolved.
Model: gpt-5.6-sol. Harness: Codex.