Skip to content

fix(web): let empty-provider composer open settings - #8482

Closed
AmAzing129 wants to merge 1 commit into
pingdotgg:mainfrom
AmAzing129:fix/composer-no-provider-settings
Closed

AmAzing129 wants to merge 1 commit into
pingdotgg:mainfrom
AmAzing129:fix/composer-no-provider-settings

Conversation

@AmAzing129

@AmAzing129 AmAzing129 commented Aug 28, 2026 •

Copy link
Copy Markdown

What Changed

When no provider is available, the composer footer used to render a disabled No provider available chip. That chip is now a link to Settings → Providers. Hovering it shows "Open provider settings". Send stays disabled until a provider is enabled.

Web and desktop share this composer. Mobile does not: providers are configured on the host.

Why

The empty-provider composer already told people to enable a provider in Settings, but the only control in that slot was disabled. There was no way through from the screen they were stuck on.

This keeps the same empty state and makes the obvious control do the thing the copy already promised.

UI Changes

Before: disabled status chip in the model-picker slot. Placeholder says to enable a provider in Settings, but nothing in the composer navigates there.

After: same chip, now a link. Click opens /settings/providers. Tooltip: "Open provider settings".

Verified on desktop with every provider disabled: the chip appears, click lands on provider settings, enabling a provider restores the model picker.

Please drop before/after screenshots into this description (the empty composer chip, then the same chip after hover/click). I could not attach image files from the CLI.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

The composer already told users to enable a provider in Settings, but the
footer chip was disabled, so there was no way through from that screen.
Make the chip a link to provider settings.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e1d7a9f-ceb3-4169-99f3-19b12a4ed6d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 28, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5745db7

Macroscope's review found this PR approvable — This is a small, isolated UI fix that makes the existing empty-provider indicator link to the already-established provider settings route. Existing provider selection and send-disable behavior remain unchanged, and the new navigation behavior has focused test coverage.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of the open-PR backlog sweep (wave 2).

Reason: Empty-provider composer already opens settings on main.
Related: #9348

Reopen if this is still wanted and you’re willing to rebase onto current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants