Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Straightforward bug fix that adds Windows-specific handling for Ctrl+V paste in the terminal, matching expected OS behavior. The change is small, well-scoped, and includes a unit test. You can add or adjust custom eligibility rules. Learn more. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. We are keeping OPEN #7698 as the review path for Windows terminal input behavior. The focused Ghostty surface test here remains useful reference. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. |
What Changed
Added Windows-specific terminal paste handling so
Ctrl+Vtriggers clipboard paste.Why
(This may have been on purpose for Windows so feel free to disregard)
When using WSL from Windows Terminal,
Ctrl+Vis handled by the Windows terminal as paste before the key reaches Linux. T3’s Windows client should provide the same behavior to avoid friction.Previously, Windows fell into the generic non-macOS path, so
Ctrl+Vwas forwarded to the WSL PTY as control-V and appeared as^V.Checklist
Note
Low Risk
Small, well-tested shortcut mapping change with no auth or data-handling impact. Linux still keeps Ctrl+V for the PTY.
Overview
Treats Ctrl+V as clipboard paste on Windows in
isTerminalPasteShortcut, instead of the previous non-mac path that required Ctrl+Shift+V and forwarded Ctrl+V as^V.macOS stays Cmd+V; Linux still uses Ctrl+Shift+V so Ctrl+V can reach the PTY. Adds a Windows unit test.
Reviewed by Cursor Bugbot for commit 9a8962d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Support
Ctrl+Vterminal paste on Windows inisTerminalPasteShortcutvkey branch ofisTerminalPasteShortcutin surface.ts to return true forCtrl+Von Windows.Cmd+V, and other non-mac platforms keepCtrl+Shift+V.Ctrl+V(notCmd+V).Ctrl+Shift+Vnow trigger paste with plainCtrl+VviaisTerminalPasteShortcut, which may conflict with existingCtrl+Vbindings in the terminal surface.Macroscope summarized 9a8962d.