fix(codex): restore pre-registration child liveness by lastobelus · Pull Request #7848 · pingdotgg/t3code

lastobelus · 2026-08-21T21:55:38Z

Upstream #7937 fixed the stale-Working bug by ignoring trailing collabAgent/activity { activityKind: "interacted" } events. A complementary registration race remains: Codex can emit a real child turn/started before either notification that identifies that child.

The runtime now records that suppressed live turn and replays an explicit collabAgent/turnStarted only when a later registration proves the turn is still live. Terminal child errors clear the recorded turn, remain authoritative across late registration, and emit a bounded start-to-failed lifecycle so every client gets an anchor without leaving the child live. Retryable errors retain the live turn. Child-scoped errors stay off the parent event stream.

This PR is intentionally limited to that residual race:

fix(server): stop completed Codex threads from staying stuck on working #7937 owns the merged adapter behavior for trailing interactions.
fix(server): status-free task updates no longer revive an idle task #7468 separately tracks generic status-free task.updated liveness hardening.

Related issue: #7726

LastCode counterpart: lastobelus#69

Validation:

43 focused Codex collaboration runtime, wire, and adapter tests passed
server typecheck passed
targeted lint, formatting, and diff checks passed
three bounded review rounds completed; all verified findings were fixed

Prepared by gpt-5.6-sol through the Codex harness.

coderabbitai · 2026-08-21T22:00:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 114bf674-3bec-4a4f-bd2e-cdfaba3d156f

📥 Commits

Reviewing files that changed from the base of the PR and between 592c598 and 3a836d7dce348331773566e6fd0c9cd9bb04c656.

📒 Files selected for processing (6)

apps/server/src/orchestration/ThreadBackgroundLiveness.test.ts
apps/server/src/orchestration/ThreadBackgroundLiveness.ts
apps/server/src/provider/Layers/CodexAdapter.test.ts
apps/server/src/provider/Layers/CodexAdapter.ts
apps/server/src/provider/Layers/CodexCollabRuntime.integration.test.ts
apps/server/src/provider/Layers/CodexSessionRuntime.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The change prevents descriptive task updates from reviving idle tasks. It preserves child-agent identity during late registration and replays recorded live turns. Tests cover liveness, child event sequencing, and pre-registration turn replay.

Changes

Lifecycle and liveness behavior

Layer / File(s)	Summary
Task liveness event handling `apps/server/src/orchestration/ThreadBackgroundLiveness.ts`, `apps/server/src/orchestration/ThreadBackgroundLiveness.test.ts`	Status-free `updated` events no longer revive idle tasks. Genuine `started` events still restore `"working"` liveness.
Child-agent lifecycle synchronization `apps/server/src/provider/Layers/CodexAdapter.ts`, `apps/server/src/provider/Layers/CodexSessionRuntime.ts`, `apps/server/src/provider/Layers/CodexAdapter.test.ts`, `apps/server/src/provider/Layers/CodexCollabRuntime.integration.test.ts`	`"interacted"` events preserve lifecycle state. Child registration preserves existing metadata and replays synthetic `turnStarted` events for previously recorded live turns.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to 3a836

The PR prevents stale interaction events from reviving idle subagents while restoring genuinely live work discovered late. A bounded lifecycle edge case remains if child turns overlap, complete out of order, or lose terminal notifications, which could cause stop or recovery handling to miss active work; merge is reasonable with explicit owner awareness and follow-up.

Suggested reviewers: t3dotgg, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the primary fix: restoring liveness for child agents registered after their turns start.
Description check	✅ Passed	The description clearly explains the race, implementation, scope, related issues, and validation results; UI details are not applicable.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>

lastobelus · 2026-08-21T22:37:51Z

@coderabbitai review

macroscopeapp · 2026-08-21T22:44:02Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes shared Codex event routing and child lifecycle state, including suppression, synthetic replay, terminal-error handling, and Stop interruption tracking. Because these changes can alter parent visibility and agent liveness across several event-ordering scenarios, the runtime behavior warrants human review.

Notes:

No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-08-21T22:59:36Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>

Dismissing prior approval to re-evaluate 94002d8

lastobelus · 2026-08-23T20:15:48Z

Refactored after #7937 merged: this PR no longer changes the interacted adapter mapping and no longer includes #7468. It now isolates only the complementary pre-registration live-turn replay. LastCode reconciliation: lastobelus#69.

Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>

(cherry picked from commit 75b66cae0de74a7ebfa5a8d017a7444660cabe57)

Upstream pingdotgg#7937 merged the core stale-Working fix by ignoring trailing Codex `interacted` events. LastCode's nightly adopted that implementation, but the rebased #48 commit still grouped two independent safeguards under the old composite port. This branch makes the ownership explicit and atomic: 1. revert LastCode #48; 2. reapply the generic status-free `task.updated` liveness hardening from pingdotgg#7468; 3. reapply the pre-registration child-turn replay from the narrowed pingdotgg#7848, including its terminal-error ordering and cross-client anchor fixes. The small net diff is intentional: the nightly had already resolved the upstream provenance without exposing an intermediate LastCode state that drops either still-needed safeguard. Upstream sources observed 2026-08-23 PDT: - pingdotgg#7937 merged at head `db85d831d4074cbbbe6c1975b7fa2421f9c10df4` (merge `4e00471d1ab340b46742565bb6ce6462160b4d0c`) - pingdotgg#7848 open at reviewed head `1123f75e9` - pingdotgg#7468 remains the upstream owner of generic liveness hardening Import method: exact commits applied with `cherry-pick -x`; review fixes were authored in pingdotgg#7848 first and then ported into this stack. Validation: - 52 focused Codex adapter, collaboration runtime, wire, and background-liveness tests passed - server typecheck passed - targeted lint, formatting, and diff checks passed - three bounded review rounds completed: correctness/edge cases, KISS/best practices, and final regression review - mandatory quick local CI passed on head `a6f42da8a` Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>