Skip to content

[codex] run grouped projects on another machine - #7424

Closed
aGamingGod1234 wants to merge 8 commits into
pingdotgg:mainfrom
aGamingGod1234:codex/grouped-machine-profiles
Closed

aGamingGod1234 wants to merge 8 commits into
pingdotgg:mainfrom
aGamingGod1234:codex/grouped-machine-profiles

Conversation

@aGamingGod1234

@aGamingGod1234 aGamingGod1234 commented Aug 18, 2026 •

Copy link
Copy Markdown

Why

The same GitHub repository opened on two machines appeared as separate projects, and a new thread could not keep the machine-specific checkout, worktree, model, or execution context when switching between them.

What changed

  • Detects matching repository projects across connected environments and shows a one-time sidebar prompt to group them or keep them separate.
  • Adds a draft-only Run on combobox beside the workspace and branch controls.
  • Shows each machine's path, checkout, workspace, model, provider, and execution settings in the picker, with unavailable machines visible but disabled.
  • Persists a profile per physical environment/project and atomically restores it when switching A → B → A.
  • Keeps started threads pinned to their original environment and project.
  • Documents the grouped-project and machine-selection workflow.

Validation

  • Focused web tests: 6 files, 214 tests passed.
  • @t3tools/web typecheck passed.
  • Targeted lint passed.
  • Formatting and git diff --check passed.
  • Real browser verification with two isolated T3 environments passed: duplicate repository detection, grouping prompt, machine picker details, and A → B → A switching.

Generated by GPT-5.6-Luna in T3 Code.

Note

Add per-machine draft profiles and environment switching for grouped projects

  • Introduces MachineDraftProfile to store per-physical-project draft state (branch, worktree, env/runtime/interaction modes, model selections) keyed by environment+project via physicalProjectProfileKey.
  • Adds composerDraftStore.switchDraftProject to atomically swap branch, worktree, modes, and model selections when switching environments on an unlocked draft, saving and restoring per-machine snapshots.
  • Reworks clearComposerDraftsEnvironment to rehome grouped drafts to a surviving environment with their machine profile intact, instead of always discarding them.
  • Adds buildEnvironmentOption and MachineProfileRow to surface connection state, provider/model preview, and execution settings in the desktop and mobile environment selectors.
  • Adds a ProjectGroupingPrompt in the sidebar that detects repositories spanning multiple environments and lets users group or keep them separate, with acknowledgement persisted to localStorage.
  • Risk: persisted PersistedDraftThreadState shape gains an optional machineProfilesByProjectKey field; existing persisted state is forward-compatible but older clients will silently drop the new field.

Macroscope summarized 6bf59f9.

Copilot AI lite review requested due to automatic review settings August 18, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 41a54f7f-0787-4a45-ab1d-d6442cefc72d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 18, 2026
Comment thread apps/web/src/machineDraftProfile.ts Outdated

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two UI-consistency findings in the new components. Everything else (reuse of Select/Menu primitives, SelectPopup's popupClassName width, Button size="xs", Alert slots) composes with the existing primitives as intended.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/MachineProfileRow.tsx Outdated
Comment thread apps/web/src/components/sidebar/ProjectGroupingPrompt.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3229da1c56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/machineDraftProfile.ts Outdated
Comment thread apps/web/src/machineDraftProfile.ts
Comment thread apps/web/src/composerDraftStore.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3229da1. Configure here.

Comment thread apps/web/src/components/BranchToolbar.tsx
@macroscopeapp

macroscopeapp Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a substantial new feature for machine-aware grouped project profiles, adding new UI components, complex state management in the draft store, and new user-facing workflows. The scope and complexity of the changes warrant human review to verify design alignment.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/web/src/machineDraftProfile.ts Outdated

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the mobile run-context menu width; the machine profile row and grouping prompt changes otherwise look consistent with the shared primitives.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/BranchToolbar.tsx Outdated

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two findings in the new machine-profile picker UI. Details inline.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/MachineProfileRow.tsx
Comment thread apps/web/src/components/BranchToolbar.tsx

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review found 2 issues in the new machine profile row. Earlier findings (mobile popup width, alert action stacking, tooltip disclosure replacing aria-label) look addressed.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/machineDraftProfile.ts
Comment thread apps/web/src/components/MachineProfileRow.tsx

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the machine-profile picker and sidebar grouping prompt. Two findings, both in newly added files; details inline.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/MachineProfileRow.tsx Outdated
Comment thread apps/web/src/components/sidebar/ProjectGroupingPrompt.tsx Outdated
@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of the open-PR backlog sweep (wave 1).

Reason: Abandoned 2k-line [codex] multi-machine grouping feature; conflicted since mid-August with no path.

Reopen if this is still wanted and you’re willing to rebase onto current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants