Skip to content

fix(web): resume an in-progress draft when returning to the index - #7422

Open
sideeffffect wants to merge 3 commits into
pingdotgg:mainfrom
sideeffffect:fix/resume-new-conversation-draft
Open

sideeffffect wants to merge 3 commits into
pingdotgg:mainfrom
sideeffffect:fix/resume-new-conversation-draft

Conversation

@sideeffffect

@sideeffffect sideeffffect commented Aug 18, 2026 •

Copy link
Copy Markdown

Problem

Start a new conversation, type into the composer, click into another thread, then return to the / landing (the app logo / "Go to threads"): you're dropped on a blank composer. The landing always mints a fresh draft in the most-recently-active project, and project recency is ranked by server threads — which ignores unsent drafts. So an in-progress draft that lives in a different project than the one you just visited is left parked in the sidebar instead of reopened.

The text isn't destroyed (invested drafts survive and get a sidebar row, per #5777), but "I came back and my message is gone" is exactly how it reads.

Fix

Make the index landing resume the most-recent draft the user has actually invested content in (across projects) before falling back to starting a fresh draft in the most-recently-active project.

  • Explicit new-thread surfaces (the + buttons, hotkeys, command palette) are untouched and still mint fresh — this only changes the "return home" landing, where resuming unsent work is what you'd expect.
  • Adds getMostRecentDraftSessionWithContent to the composer draft store (non-promoted + composerDraftHasUserContent, newest by createdAt), with unit coverage.

Verification

apps/web typecheck, lint, and composerDraftStore.test.ts pass (incl. two new cases: resumes the newest invested draft across projects / ignores empty sessions; returns null when nothing is invested).

This is a routing/state change with no static visual; the difference is whether / reopens your in-progress draft or a blank one. Happy to record a short before/after clip if that's preferred.

Claude Opus 4.8 via Claude Code.


Note

Medium Risk
Changes default index routing and which draft opens on “return home,” though explicit new-thread entry points are unchanged and missing projects skip resume.

Overview
Visiting / no longer always mints a blank draft in the most-recently-active project. IndexDraftLanding now looks for a resumable in-progress draft first and replace-navigates to /draft/$draftId when that draft’s project still exists; otherwise it keeps the old behavior of starting a fresh draft in the latest project.

The composer draft store gains getMostRecentDraftSessionWithContent, which picks the newest non-promoting draft session (by createdAt) that has real user content via composerDraftHasUserContent, including across projects and ignoring empty newer sessions. Unit tests cover cross-project selection and the empty-draft case.

Reviewed by Cursor Bugbot for commit 326f2d5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Resume in-progress drafts when navigating to the index route

  • Adds getMostRecentDraftSessionWithContent to the composer draft store, which returns the most recently created, non-promoting draft session that has user content across all projects.
  • Updates the IndexDraftLanding component in _chat.index.tsx to check for a resumable draft on load; if found and its project still exists, navigates to /draft/$draftId instead of creating a new draft.
  • Behavioral Change: visiting the index route no longer always creates a fresh draft — users with an in-progress draft are redirected to it.

Macroscope summarized 326f2d5.

Summary by CodeRabbit

  • New Features

    • Returning to the chat home now resumes the most recent in-progress draft containing user-entered content.
    • Drafts are resumed only when their associated project is still available.
    • Drafts without content or currently being promoted are skipped.
  • Bug Fixes

    • Prevented users from being redirected to a new thread when an existing draft can be resumed.

Typing into a new conversation, visiting another thread, then coming back to
the "/" landing dropped the user on a blank composer: the landing always
started a fresh draft in the most-recently-active project (ranked by server
threads, which ignores unsent drafts), so an in-progress draft in a different
project was left parked in the sidebar instead of reopened. The typed text was
not destroyed, but "come back and it's blank" reads as losing work.

Make the index landing resume the most-recent draft the user has actually
invested content in (across projects) before falling back to a fresh draft.
Explicit new-thread surfaces (the "+" buttons, hotkeys, palette) still mint
fresh, so this only changes the "return home" path.

Adds getMostRecentDraftSessionWithContent to the composer draft store, with
unit coverage.

Claude Opus 4.8 via Claude Code.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 147afed8-19db-4ad1-8972-6dfaaf67ec5f

📥 Commits

Reviewing files that changed from the base of the PR and between 6c58362 and 25f4e1d.

📒 Files selected for processing (3)
  • apps/web/src/composerDraftStore.test.ts
  • apps/web/src/composerDraftStore.ts
  • apps/web/src/routes/_chat.index.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The composer draft store now selects the newest draft with user content. The chat index route resumes that draft when its project exists, and tests cover selection across projects and empty drafts.

Changes

Draft session resume

Layer / File(s) Summary
Draft session selection and validation
apps/web/src/composerDraftStore.ts, apps/web/src/composerDraftStore.test.ts
The store exposes getMostRecentDraftSessionWithContent. It skips promoting sessions and drafts without user content, then returns the newest remaining session. Tests cover ordering and the empty result.
Chat index resume navigation
apps/web/src/routes/_chat.index.tsx
The startup effect checks the selected draft and its project. When both exist, it navigates to /draft/$draftId with route replacement. Otherwise, it retains the new-thread startup path. Dependency tracking now includes bootstrap state, navigation, and projects.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 25f4e

The landing page now resumes the newest content-bearing draft when its project exists, otherwise continuing to create a fresh draft. No concrete current-head merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant IndexDraftLanding
  participant ComposerDraftStore
  participant Projects
  participant Router
  IndexDraftLanding->>ComposerDraftStore: getMostRecentDraftSessionWithContent()
  ComposerDraftStore-->>IndexDraftLanding: ProjectDraftSession or null
  IndexDraftLanding->>Projects: verify draft project exists
  Projects-->>IndexDraftLanding: matching project or no match
  IndexDraftLanding->>Router: replace route with /draft/$draftId
Loading

Suggested reviewers: juliusmarminge, t3dotgg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: resuming an in-progress draft when returning to the index.
Description check ✅ Passed The description explains the problem, the fix, scope, behavior, and verification. It does not use the template headings exactly and omits the checklist, but it provides the required information and ad…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 18, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing navigation behavior - automatically resuming drafts with content when returning to the index instead of creating blank ones. While well-tested and scoped, this is a feature change affecting core UX rather than a simple bug fix.

You can add or adjust custom eligibility rules. Learn more.

…ersation-draft

# Conflicts:
#	apps/web/src/routes/_chat.index.tsx
…ersation-draft

# Conflicts:
#	apps/web/src/routes/_chat.index.tsx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant