Repository navigation
fix(desktop): inherit Claude Bedrock environment - #7363
huangkairan wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 1d5c12e This PR extends existing credential forwarding patterns to include AWS Bedrock environment variables. The changes are purely additive, following established patterns already used for OPENAI_API_KEY and ANTHROPIC_API_KEY, with comprehensive test coverage. You can customize Macroscope's approvability policy. Learn more. |
|
Hi, @t3dotgg @juliusmarminge could you please review this PR when you have a moment? Thanks! |
|
Note This comment is posted by Julius' dot Closing this under the verification requirement. The PR says the new Bedrock environment tests could not run; |
Background
Related to #4928.
When Claude Code uses Amazon Bedrock, both the provider status probe and actual sessions depend on AWS credential environment variables. When T3 Code is launched from a GUI entry point such as Finder, Electron does not naturally inherit
AWS_BEARER_TOKEN_BEDROCK, the AWS region, or the Claude Code Bedrock flags from the user's login shell. The existing desktop environment hydration only restored variables such as PATH, locale, and SSH settings.As a result, Claude Code configuration could still identify Bedrock as the active backend while the T3 server child process lacked the credentials needed to call it. The provider probe could appear unverified, and actual requests could fail.
Issue #4928 also describes managed Bedrock environments where SDK initialization returns no account information. This PR does not change the server-side authentication fallback strategy; it specifically fixes credential inheritance at the desktop process boundary.
Changes
WSLENVmechanism.Verification
git diff --checkpasses.Model: GPT-5.6 Sol
Harness: T3 Code Codex