feat(web): add toggleable confirmation before unpinning a thread

[UtkarshUsername]

Closes #6929

What Changed

Added a toggle to ask for confirmation before the "Unpin thread" action fires. The dialog shows the thread name (Unpin thread "Thread Title"?), a description and defaults to Cancel. The user must explicitly confirm to proceed. The confirmation toggle is turned off by default.

Why

The unpin action previously took effect immediately, making it easy to misclick while navigating the thread context menu. Pinned threads are usually curated deliberately, so an accidental unpin means losing a thread from a carefully organized list with no undo. A confirmation step matches the existing pattern used for archive and delete, and prevents accidental disruption.

UI Changes

unpin.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included screenshots for any UI changes
• I included a video for animation/interaction changes

---

Note

Low Risk
Opt-in UX guard around unpin with default false; no auth, data, or server contract changes beyond a new client setting field.

Overview
Adds an optional Unpin confirmation setting (confirmThreadUnpin, default off) so unpinning can require an explicit dialog before the thread leaves the pinned section.

When enabled, sidebar unpin, thread context menu, and mod+shift+p route through confirmAndUnpinThread, which shows the thread title and only calls unpinThread if the user confirms (or skips the dialog when the setting is off or dialogs are unavailable). Settings → General gets a searchable toggle with reset/dirty tracking, and user docs note the shortcut behavior.

Pinning and the underlying unpin mutation are unchanged; behavior stays immediate unless the user turns the setting on.

^{Reviewed by Cursor Bugbot for commit 08c0935. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add toggleable confirmation before unpinning threads in web app

• Adds confirmThreadUnpin boolean field (default false) to ClientSettingsSchema in settings.ts and allows patching via ClientSettingsPatch.
• Implements confirmAndUnpinThread in useThreadActions.ts using requestThreadUnpinConfirmation to prompt the user via localApi.dialogs.confirm when enabled; cancellations result in a no-op.
• Swaps unpinThread for confirmAndUnpinThread in ChatView.tsx, Sidebar.tsx, and useThreadActionMenu.ts.
• Adds a settings toggle in SettingsPanels.tsx under General, with search indexing in settingsSearch.ts and reset-to-default support.
• Behavioral Change: all unpin entry points now route through confirmAndUnpinThread; with confirmThreadUnpin left at its default false, behavior is unchanged, but any caller still invoking unpinThread directly bypasses the confirmation.

^{Macroscope summarized 08c0935.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a0f69bbc-f71c-4c24-ab81-09b2f173eb58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding: the new unpin setting is reset by "Restore defaults" but never reported as changed, so the restore affordance stays disabled and silently omits it. Details inline.

^{Posted via Macroscope — UI Consistency}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit aee3bb5a12e6c3edf1641096d1f82ec821e6f230. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved at 08c0935

Macroscope's review found this PR approvable — This is a small, opt-in web UX safeguard with a false-by-default client setting, backward-compatible persistence, focused tests, and no server or sensitive-domain changes. Existing unpin behavior remains unchanged unless a user explicitly enables the confirmation option.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

Reviewed the new "Unpin confirmation" setting and its two call sites. The settings row itself composes the shared SettingsRow / Switch / SettingResetButton primitives correctly and the restore-defaults wiring is now complete. Two consistency issues remain, both in apps/web/src.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate af7a94c