fix(web): align the sidebar T3 Code lockup on a shared baseline - #7312
meisolated wants to merge 5 commits into
Conversation
The wordmark and "Code" were centered as two separate boxes with a -translate-y-px nudge on the text. Centering aligns boxes, not baselines, so the pair only lined up for a font whose ascent and descent match the default stack: with a custom interface font (Settings -> Appearance) the word drifted ~2px above the mark, and a fixed 1px nudge does not scale with the interface font size either. Put the mark and the word in one line box so the mark rides the text baseline as an inline replaced element, and replace the fixed gap with a real word space that scales with the font.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
One blocking issue: the class-string change breaks an existing source-text assertion in threadSidebarWidth.test.ts. Details inline.
Posted via Macroscope — UI Consistency
ApprovabilityVerdict: Approved 0b8bf89 Pure CSS layout fix adjusting text/icon baseline alignment in the sidebar brand lockup. No logic or runtime behavior changes - only Tailwind class modifications and corresponding test update. You can customize Macroscope's approvability policy. Learn more. |
The wordmark guard pinned the exact class substring, which included the gap-1 the lockup no longer uses now that the space is a real word space.
Dismissing prior approval to re-evaluate 0b8bf89
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. Closing this appearance-only PR in the backlog cleanup. It aligns the sidebar wordmark with custom fonts but changes no navigation or state. The shared-baseline adjustment can be included when the sidebar layout is next edited instead of retaining a separate branch for it. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. If GitHub does not let you reopen it, leave a comment here and we'll take another look. |
|
Dear Theo,
Thank you for the update. That sounds perfectly fine, and I completely
understand the reasoning behind the backlog cleanup.
Best regards,
Vivek
…On Thu, 27 Aug 2026 at 16:56, Theo Browne ***@***.***> wrote:
Closed #7312 <#7312>.
—
Reply to this email directly, view it on GitHub
<#7312?email_source=notifications&email_token=ALRIIERQYPCGJGUACSST5PT5MALEVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBQHE4TSOBUHEZDPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-30099984927>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRIIEQHUUDLCHUCF2VN6MD5MALEVAVCNFSNUABGKJSXA33TNF2G64TZHMYTCNJTGEZTAMZUHE5US43TOVSTWNJRG4YDIMRTGY2DJILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ALRIIERPA3GMPBOWQFJKYY35MALEVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBQHE4TSOBUHEZDPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ALRIIEVHACEB4PAYPRA7X2D5MALEVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBQHE4TSOBUHEZDPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The wordmark and "Code" in the sidebar header were centered as two separate flex boxes, with a
-translate-y-pxnudge on the text to make them look level. Centering aligns boxes, not baselines, so the pair only lined up for a font whose ascent and descent match the default stack. With a custom interface font (Settings -> Appearance) the word drifts above the mark — measured ~2px on THICCCBOI (0.80em/0.20em) vs Segoe UI (1.079em/0.251em) — and the fixed 1px nudge does not scale with the interface font size either.Now the mark and the word share one line box, so the mark rides the text baseline as an inline replaced element and follows whatever font is set.
align-baselineoverrides Tailwind preflight'ssvg { vertical-align: middle }. The fixedgap-1becomes a real word space that scales with the font.Before
"Code" sits ~2px above the mark's baseline (interface font THICCCBOI at 16px).
After
Mark and word end on the same baseline row.
Note
Low Risk
Presentation-only change to the sidebar header link and a string assertion in a width regression test.
Overview
Fixes T3 + Code misalignment in the sidebar brand when users pick a custom interface font: the old flex row with
-translate-y-pxon the label only looked right for the default font metrics.The lockup is now a single truncating text line—the wordmark is an inline SVG with
align-baseline(overriding preflight’svertical-align: middleon SVGs), and spacing uses a normal word space instead ofgap-1. The regression test inthreadSidebarWidth.test.tsis updated to assert the link’s desktop layout classes still match the sidebar width contract.Reviewed by Cursor Bugbot for commit ce1b7a8. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Align the T3 Code wordmark SVG to the text baseline in the sidebar
Fixes a visual misalignment between the
T3WordmarkSVG and the "Code" label in the sidebar brand link. The SVG's class is changed from block/flex layout toinlinewithalign-baseline, and the two elements are wrapped in a single truncating span, replacing the previous flex gap approach.Macroscope summarized ce1b7a8.