Skip to content

fix(threads): keep snoozed threads hidden when work finishes - #7179

Closed
maslinedwin wants to merge 1 commit into
pingdotgg:mainfrom
maslinedwin:fix/snooze-ignore-completion
Closed

maslinedwin wants to merge 1 commit into
pingdotgg:mainfrom
maslinedwin:fix/snooze-ignore-completion

Conversation

@maslinedwin

@maslinedwin maslinedwin commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #6368. Turn completion no longer raises a snoozed thread's hand. Approvals, user-input, fresh errors, and the scheduled wake time still surface it.

What Changed

threadRaisedHandWhileSnoozed no longer treats a turn that completed after snoozedAt as a raised hand. threadWokeAt no longer reports that completion as an early wake.

Why

Snooze is a time-based attention overlay. Work finishing updates execution state only. Completing a turn was unsnoozing the thread in the sidebar before the chosen wake time.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Note

Low Risk
Behavior change is localized to client-runtime snooze classification and sidebar wake UX, with tests updated; no auth, persistence, or API contract changes.

Overview
Snooze no longer treats turn completion as “raise your hand.” Threads that finish a run while snoozed stay classified as snoozed until the scheduled wake time or a user-blocking signal (pending approval, user input, or a fresh session error).

In threadSettled.ts, threadRaisedHandWhileSnoozed drops the branch that compared latestTurn.completedAt to snoozedAt, and threadWokeAt no longer reports that completion as an early wake (including the special-case that used completion time after a hand-raise). effectiveSnoozed therefore keeps snoozed threads hidden when work merely completes.

Sidebar and server comments are aligned: the Woke pill clears on visit only for blocking early wakes, not for completion; the decider documents that completion is not a raised hand. Tests in threadSnoozed.test.ts flip expectations and add coverage that approvals still unsnooze after completion.

Reviewed by Cursor Bugbot for commit 90f8477. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Keep snoozed threads hidden when work completes without requiring input

  • threadRaisedHandWhileSnoozed in threadSettled.ts no longer treats a post-snooze turn completion as a raised hand; only pending approvals, pending user input, or a fresh session error qualify.
  • threadWokeAt no longer returns a turn's completedAt as an early wake timestamp; raised-hand wakes now report session.updatedAt or snoozedAt, and timer-elapsed wakes report snoozedUntil.
  • Behavioral Change: threads that finish work while snoozed stay hidden until the snooze timer elapses, rather than surfacing immediately in the sidebar.

Macroscope summarized 90f8477.

Snooze is time-based. Completing a turn no longer raises a thread's
hand, so a working thread stays in the snoozed shelf until the chosen
wake time, an explicit unsnooze, or a real blocking request.
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2a067ad-1fc8-4b57-adf5-20ec4e740fc2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 16, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR changes runtime behavior for when snoozed threads resurface to users, removing completion as a wake trigger. As a product behavior change (not a straightforward bug fix) by a new contributor, this warrants human review to verify the intended product behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge

Copy link
Copy Markdown
Member

Thanks for the PR. We're not taking changes to the orchestration and provider layers right now: that part of the server is being rewritten for V2, and merging into the current code would either conflict with or be thrown away by that work.

Closing for now. If this is still an issue once V2 lands, please reopen (or open a fresh PR against the new code) and we'll take a proper look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: completed work wakes snoozed threads and breaks subsequent snoozing

2 participants