Fix for issue 5917 - #6056
Fix for issue 5917#6056mohamedmastouri-hue wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit baa212fb0f58003f4007d1f4a3f8274960c02206. Configure here.
ApprovabilityVerdict: Needs human review This PR modifies Windows keyboard shortcuts in the terminal (Ctrl+C/V instead of Ctrl+Shift+C/V) and adds a context menu. While the copy shortcut is properly guarded to only trigger when there's a selection, this is a runtime behavior change to keyboard handling that warrants human review. You can customize Macroscope's approvability policy. Learn more. |
f2df8c3 to
baa212f
Compare
baa212f to
78eb7ea
Compare
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. This changes Windows terminal paste and context menu behavior. #7698 is the retained review path for this repair, so we are closing this parallel branch. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. |

Fixes issue #5917
Note
Low Risk
Localized terminal UX and shortcut logic with unit test updates; no auth, data, or API contract changes beyond an optional surface callback.
Overview
Right-click Copy/Paste is wired through an optional
onContextMenuonGhosttyTerminalSurface: when application mouse tracking is off, the thread terminal drawer shows the nativelocalApimenu (Copy when there is a selection, always Paste) and routes actions through the existing copy handler and bracketed paste encoding.Keyboard copy/paste detection now branches on platform: Windows uses
Ctrl+C/Ctrl+V(including with Shift); Linux still requiresCtrl+Shift+C/Ctrl+Shift+Vso plainCtrl+Cstays available for SIGINT; macOS is unchanged (Cmdfor copy/paste,Ctrl+Cnot treated as copy). Tests insurface.test.tswere updated for the Windows vs Linux split.Reviewed by Cursor Bugbot for commit 78eb7ea. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add right-click context menu and fix copy/paste shortcuts in terminal
ThreadTerminalDrawer's terminal viewport with Copy and Paste options. Copy is only shown when text is selected; Paste reads from the clipboard and writes to the terminal viaterminal.core.encodePaste.isTerminalCopyShortcutandisTerminalPasteShortcutin surface.ts to recognize Ctrl+C and Ctrl+V on Windows (previously required Ctrl+Shift+C/V on non-macOS platforms).onContextMenucallback toGhosttyTerminalSurfaceOptions, forwarded fromGhosttyTerminalSurface.onContextMenuwhen mouse tracking is not active.Macroscope summarized 78eb7ea.