Skip to content

Fix for issue 5917 - #6056

Closed
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-5917
Closed

mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-5917

Conversation

@mohamedmastouri-hue

@mohamedmastouri-hue mohamedmastouri-hue commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes issue #5917


Note

Low Risk
Localized terminal UX and shortcut logic with unit test updates; no auth, data, or API contract changes beyond an optional surface callback.

Overview
Right-click Copy/Paste is wired through an optional onContextMenu on GhosttyTerminalSurface: when application mouse tracking is off, the thread terminal drawer shows the native localApi menu (Copy when there is a selection, always Paste) and routes actions through the existing copy handler and bracketed paste encoding.

Keyboard copy/paste detection now branches on platform: Windows uses Ctrl+C / Ctrl+V (including with Shift); Linux still requires Ctrl+Shift+C / Ctrl+Shift+V so plain Ctrl+C stays available for SIGINT; macOS is unchanged (Cmd for copy/paste, Ctrl+C not treated as copy). Tests in surface.test.ts were updated for the Windows vs Linux split.

Reviewed by Cursor Bugbot for commit 78eb7ea. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add right-click context menu and fix copy/paste shortcuts in terminal

  • Adds a right-click context menu in ThreadTerminalDrawer's terminal viewport with Copy and Paste options. Copy is only shown when text is selected; Paste reads from the clipboard and writes to the terminal via terminal.core.encodePaste.
  • Updates isTerminalCopyShortcut and isTerminalPasteShortcut in surface.ts to recognize Ctrl+C and Ctrl+V on Windows (previously required Ctrl+Shift+C/V on non-macOS platforms).
  • Adds an optional onContextMenu callback to GhosttyTerminalSurfaceOptions, forwarded from GhosttyTerminalSurface.onContextMenu when mouse tracking is not active.

Macroscope summarized 78eb7ea.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 04cb98f4-f757-427c-a64c-5273141ee6ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
Comment thread apps/web/src/components/ThreadTerminalDrawer.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit baa212fb0f58003f4007d1f4a3f8274960c02206. Configure here.

Comment thread apps/web/src/components/ThreadTerminalDrawer.tsx
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR modifies Windows keyboard shortcuts in the terminal (Ctrl+C/V instead of Ctrl+Shift+C/V) and adds a context menu. While the copy shortcut is properly guarded to only trigger when there's a selection, this is a runtime behavior change to keyboard handling that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@mohamedmastouri-hue
mohamedmastouri-hue force-pushed the fix-issue-5917 branch 2 times, most recently from f2df8c3 to baa212f Compare August 10, 2026 20:51
@t3dotgg

t3dotgg commented Aug 28, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This changes Windows terminal paste and context menu behavior. #7698 is the retained review path for this repair, so we are closing this parallel branch.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotgg t3dotgg closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants