Skip to content

fix(mobile): keep iPadOS Threads toolbar visible after resizing - #4898

Closed
PixPMusic wants to merge 3 commits into
pingdotgg:mainfrom
PixPMusic:fix/ipad-threads-toolbar-resize
Closed

PixPMusic wants to merge 3 commits into
pingdotgg:mainfrom
PixPMusic:fix/ipad-threads-toolbar-resize

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Replacement PR: #10629 contains the tested rebase from the original branch, PixPMusic:fix/ipad-threads-toolbar-resize. This PR remains closed because GitHub rejected reopening it.

On iPadOS 26, widening the Threads window and then shrinking it can leave the native search toolbar wider than the window, clipping the filter and new-task buttons. This PR lets the toolbar shrink within the current safe area and return to its preferred width when the iPad window expands.

The native toolbar now uses a preferred width with required safe-area edge constraints. The iOS split-view Home route clears the compact toolbar when the thread list moves into the sidebar. The rebase preserves current main's keyboard-editing priorities and Android header behavior.

Platform scope

This fixes iPadOS window resizing. #5385 restored Android tablet/foldable sidebar controls and did not contain these native iOS constraint changes. The resize defect remains reproducible on main. The changed constraints are in the shared iOS native toolbar implementation.

Before / after

Fresh captures from the same seeded environment on an iPad Pro 13-inch (M5), iPadOS 26.5. A left-tiled window narrows when the iPad rotates from landscape to portrait. The baseline uses main's native constraints at e0e0bcb115; the after capture uses this PR. Capture orientation is normalized for comparison.

Before: controls clipped After: controls remain visible
iPadOS Threads after narrowing on main: filter and compose buttons are clipped at the window edges iPadOS Threads after narrowing with the fix: filter, search, and compose controls fit inside the window

Before recording · After recording, including widening again

Verification

  • Rebased onto main at d081ab7abc; migrated the native change to react-native-screens@4.26.2.
  • Fresh native Debug build and launch on the iPad simulator pass.
  • Reproduced clipping with main's native constraints; verified narrowing and widening with this PR.
  • Filter menu and new-task project picker open at the narrow width; returning to full-screen split view clears the compact bottom toolbar.
  • pnpm exec vp run --filter @t3tools/mobile typecheck passes.
  • Targeted formatting passes; targeted lint reports one pre-existing react(set-state-in-effect) warning outside this change.
  • git diff --check passes.

Models: GPT-5.6 Sol (original implementation), GPT-6 (rebase and verification) | Harness: Codex in T3 Code

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c292f793-e7a7-413c-a4fc-076a790697f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 30, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 738abd7. Configure here.

Comment thread patches/react-native-screens@4.25.2.patch
@macroscopeapp

macroscopeapp Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8993b5a

Macroscope's review found this PR approvable — This is a self-contained mobile UI bug fix for toolbar visibility after resizing. Changes are limited to iOS-specific toolbar item clearing and simplifying native layout constraints, with no broader runtime implications.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 30, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 30, 2026 07:05

Dismissing prior approval to re-evaluate 657d22c

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 30, 2026
@PixPMusic
PixPMusic force-pushed the fix/ipad-threads-toolbar-resize branch from 657d22c to d2b3e29 Compare August 3, 2026 16:07
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 3, 2026 16:07

Dismissing prior approval to re-evaluate d2b3e29

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 3, 2026
@PixPMusic
PixPMusic force-pushed the fix/ipad-threads-toolbar-resize branch from d2b3e29 to 611d5e3 Compare August 10, 2026 07:58
@PixPMusic
PixPMusic force-pushed the fix/ipad-threads-toolbar-resize branch from 611d5e3 to 8993b5a Compare August 20, 2026 03:07
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 20, 2026 03:07

Dismissing prior approval to re-evaluate 8993b5a

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 20, 2026
@t3dotgg t3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of the open-PR backlog sweep (wave 1).

Reason: Superseded by #5385 (same author) restoring Android tablet thread controls.
Related: #5385

Reopen if this is still wanted and you’re willing to rebase onto current main.

@PixPMusic PixPMusic changed the title fix(mobile): keep Threads toolbar visible after resizing fix(mobile): keep iPadOS Threads toolbar visible after resizing Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants