Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 738abd7. Configure here.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a self-contained mobile UI bug fix for toolbar visibility after resizing. Changes are limited to iOS-specific toolbar item clearing and simplifying native layout constraints, with no broader runtime implications. You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 657d22c
657d22c to
d2b3e29
Compare
Dismissing prior approval to re-evaluate d2b3e29
d2b3e29 to
611d5e3
Compare
611d5e3 to
8993b5a
Compare
Dismissing prior approval to re-evaluate 8993b5a

Replacement PR: #10629 contains the tested rebase from the original branch,
PixPMusic:fix/ipad-threads-toolbar-resize. This PR remains closed because GitHub rejected reopening it.On iPadOS 26, widening the Threads window and then shrinking it can leave the native search toolbar wider than the window, clipping the filter and new-task buttons. This PR lets the toolbar shrink within the current safe area and return to its preferred width when the iPad window expands.
The native toolbar now uses a preferred width with required safe-area edge constraints. The iOS split-view Home route clears the compact toolbar when the thread list moves into the sidebar. The rebase preserves current
main's keyboard-editing priorities and Android header behavior.Platform scope
This fixes iPadOS window resizing. #5385 restored Android tablet/foldable sidebar controls and did not contain these native iOS constraint changes. The resize defect remains reproducible on
main. The changed constraints are in the shared iOS native toolbar implementation.Before / after
Fresh captures from the same seeded environment on an iPad Pro 13-inch (M5), iPadOS 26.5. A left-tiled window narrows when the iPad rotates from landscape to portrait. The baseline uses
main's native constraints ate0e0bcb115; the after capture uses this PR. Capture orientation is normalized for comparison.Before recording · After recording, including widening again
Verification
mainatd081ab7abc; migrated the native change toreact-native-screens@4.26.2.main's native constraints; verified narrowing and widening with this PR.pnpm exec vp run --filter @t3tools/mobile typecheckpasses.react(set-state-in-effect)warning outside this change.git diff --checkpasses.Models: GPT-5.6 Sol (original implementation), GPT-6 (rebase and verification) | Harness: Codex in T3 Code