Add Alpha-specific app branding - #4331
danieliser wants to merge 4 commits into
Conversation
📝 WalkthroughWalkthroughAlpha channel support now covers sidebar backdrop artwork and desktop icon assets, including stage resolution, SVG rendering, macOS export configuration, asset paths, and patched-build icon selection. ChangesSidebar alpha backdrop
Alpha desktop icon assets
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
@claude review |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
350fedc to
4bc1838
Compare
|
@coderabbitai review |
|
@codex review |
|
@claude review once |
✅ Action performedReview finished.
|
ApprovabilityVerdict: Approved This PR adds alpha-channel branding (visual theming and icon assets) following the same established patterns as existing nightly and dev variants. The changes are purely additive, self-contained, and include tests. You can customize Macroscope's approvability policy. Learn more. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What Changed
Why
Alpha builds had no channel-specific visual identity and used the production macOS icon, which made parallel installs difficult to distinguish. This gives Alpha a recognizable but restrained identity without changing production or Nightly behavior.
UI Changes
Before, Alpha had no stage backdrop and used the production macOS icon. After, Alpha renders the dawn artwork in full and compact sidebar surfaces and packages with the matching sunrise icon.
Verification
vp run icons:checkcould not be rerun because the installed Icon Composer exporter predates the repository’s required design-generation format. Asset-resolution and packaging tests cover the committed PNG and layered source.Checklist