Add search to new-thread project picker - #4259
colonelpanic8 wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Self-contained UI enhancement adding search to an existing project picker dropdown. Uses existing Combobox component, implements straightforward client-side filtering, and includes comprehensive tests. No backend, API, or security implications. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 14cbec2
32a2bd7 to
12a2d75
Compare
Dismissing prior approval to re-evaluate af5decc
1 similar comment
19c6cae to
a8bcd66
Compare
Dismissing prior approval to re-evaluate e3fbb39
57871a2 to
3d3310b
Compare
Dismissing prior approval to re-evaluate 064fa4b
b872596 to
8187138
Compare
ece9841 to
a3d1935
Compare
a3d1935 to
0e8327b
Compare
Dismissing prior approval to re-evaluate 0e8327b

Summary
Verification
vp test run src/components/chat/draftHeroProjectSearch.test.ts --project unitvp lintandvp fmton the changed filespnpm run typecheckinapps/webIsolated exact-head browser verification of incremental search completed against disposable projects; the server and test data were stopped and removed afterward.
Exact-head evidence
Revalidated at 064fa4bb9fc2 on current main (9a0a071): focused tests, vp check, and vp run typecheck passed. The capture uses only disposable local projects.
Note
Low Risk
UI-only change to project selection on the new-thread draft hero, with logic covered by unit tests and no auth or data-path changes.
Overview
Replaces the draft hero project menu with a searchable combobox so users can narrow projects by name or workspace path while starting a new thread.
Filtering is client-side via new
draftHeroProjectSearchhelpers: multi-token matching (including grouped member titles/paths), picker state that clears the query on close, guards so stale highlights cannot switch projects after filtering, and IME-safe Enter handling in the search field. The combobox uses auto-highlight on the first match for keyboard selection; New project stays as a sticky footer action and only fires after explicit keyboard or pointer intent so it does not steal focus from search.Reviewed by Cursor Bugbot for commit b3408bb. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add search to the new-thread project picker in
DraftHeroHeadlineDraftHeroHeadline.tsx, filtering projects by title, workspace root, and group member search terms.draftHeroProjectSearch.tswith a reducer for{open, query}state (query clears on close), a multi-token case-insensitive filter, an IME Enter detection util, and a visibility guard to prevent acting on selections no longer in filtered results.Macroscope summarized b3408bb.
Current combined-stack UI evidence (2026-07-24)
Captured from PR head
a1e3bc69a67caa3ffe6e2afa1fad5bbd65097782on upstream mainece05087a70e94efcd57441337fa1249559362ba, using combined integration4dd4cef40and package/nix/store/pf7fjqw8ykkdgayf3ywsbgxxp6wi1m42-t3code-0.0.29-patched-main-20260724.The animation shows the draft project picker filtering incrementally to Canvas Components and Enter selecting the only visible result. All names and paths are disposable seed data.