Skip to content

Add search to new-thread project picker - #4259

Closed
colonelpanic8 wants to merge 6 commits into
pingdotgg:mainfrom
colonelpanic8:t3code/searchable-new-thread-projects
Closed

colonelpanic8 wants to merge 6 commits into
pingdotgg:mainfrom
colonelpanic8:t3code/searchable-new-thread-projects

Conversation

@colonelpanic8

@colonelpanic8 colonelpanic8 commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • replace the new-thread project menu with a searchable picker
  • narrow candidates incrementally by project name or workspace path as the user types
  • auto-highlight the first remaining candidate so Enter selects it
  • preserve the existing New project action

Verification

  • vp test run src/components/chat/draftHeroProjectSearch.test.ts --project unit
  • vp lint and vp fmt on the changed files
  • pnpm run typecheck in apps/web

Isolated exact-head browser verification of incremental search completed against disposable projects; the server and test data were stopped and removed afterward.

Exact-head evidence

Revalidated at 064fa4bb9fc2 on current main (9a0a071): focused tests, vp check, and vp run typecheck passed. The capture uses only disposable local projects.

Searchable new-thread project picker filtered to Cedar Docs


Note

Low Risk
UI-only change to project selection on the new-thread draft hero, with logic covered by unit tests and no auth or data-path changes.

Overview
Replaces the draft hero project menu with a searchable combobox so users can narrow projects by name or workspace path while starting a new thread.

Filtering is client-side via new draftHeroProjectSearch helpers: multi-token matching (including grouped member titles/paths), picker state that clears the query on close, guards so stale highlights cannot switch projects after filtering, and IME-safe Enter handling in the search field. The combobox uses auto-highlight on the first match for keyboard selection; New project stays as a sticky footer action and only fires after explicit keyboard or pointer intent so it does not steal focus from search.

Reviewed by Cursor Bugbot for commit b3408bb. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add search to the new-thread project picker in DraftHeroHeadline

  • Replaces the menu-based project selector with a searchable combobox in DraftHeroHeadline.tsx, filtering projects by title, workspace root, and group member search terms.
  • Adds draftHeroProjectSearch.ts with a reducer for {open, query} state (query clears on close), a multi-token case-insensitive filter, an IME Enter detection util, and a visibility guard to prevent acting on selections no longer in filtered results.
  • The "New project" action is a sticky item at the bottom of the list with collision-safe key generation; it requires keyboard navigation intent before it can be selected.

Macroscope summarized b3408bb.

Current combined-stack UI evidence (2026-07-24)

Captured from PR head a1e3bc69a67caa3ffe6e2afa1fad5bbd65097782 on upstream main ece05087a70e94efcd57441337fa1249559362ba, using combined integration 4dd4cef40 and package /nix/store/pf7fjqw8ykkdgayf3ywsbgxxp6wi1m42-t3code-0.0.29-patched-main-20260724.

The animation shows the draft project picker filtering incrementally to Canvas Components and Enter selecting the only visible result. All names and paths are disposable seed data.

Searchable draft project picker interaction

Searchable draft project picker filtered to Cedar Docs

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b95a8bed-8062-46c0-858c-7b042bcb1a41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 22, 2026
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Self-contained UI enhancement adding search to an existing project picker dropdown. Uses existing Combobox component, implements straightforward client-side filtering, and includes comprehensive tests. No backend, API, or security implications.

You can customize Macroscope's approvability policy. Learn more.

Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 10:36

Dismissing prior approval to re-evaluate 14cbec2

Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch from 32a2bd7 to 12a2d75 Compare July 22, 2026 12:07
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 12:20

Dismissing prior approval to re-evaluate af5decc

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

BEFORE/AFTER SCREENSHOTS FOR UI CHANGES
CleanShot 2026-07-22 at 14 32 06@2x

1 similar comment
@juliusmarminge

Copy link
Copy Markdown
Member

BEFORE/AFTER SCREENSHOTS FOR UI CHANGES
CleanShot 2026-07-22 at 14 32 06@2x

@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch 2 times, most recently from 19c6cae to a8bcd66 Compare July 22, 2026 15:43
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 15:53

Dismissing prior approval to re-evaluate e3fbb39

Comment thread apps/web/src/components/chat/draftHeroProjectSearch.ts
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch 2 times, most recently from 57871a2 to 3d3310b Compare July 22, 2026 16:22
Comment thread apps/web/src/components/chat/draftHeroProjectSearch.ts Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 16:37

Dismissing prior approval to re-evaluate 064fa4b

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch 2 times, most recently from b872596 to 8187138 Compare July 23, 2026 16:04
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 26, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 26, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch from ece9841 to a3d1935 Compare July 27, 2026 11:14
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 27, 2026
colonelpanic8 added a commit to colonelpanic8/t3code that referenced this pull request Jul 28, 2026
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch from a3d1935 to 0e8327b Compare July 28, 2026 02:07
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 28, 2026 02:07

Dismissing prior approval to re-evaluate 0e8327b

@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of the open-PR backlog sweep (wave 1).

Reason: Jul conflicted picker search; superseded in spirit by later picker work e.g. #7392.
Related: #7392

Reopen if this is still wanted and you’re willing to rebase onto current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants