[Zheruel]

Problem

Keep completed Antigravity titles and validated installs successful when deleting their temporary files is slow.

Recursive removal currently runs in the server’s shared filesystem pool and inside generation/validation deadlines. It can stall unrelated file reads and turn successful work into a timeout and retry (#23877). Startup uses the same recursive removal.

Change

One cleanup subprocess deletes sequentially with fs.rmSync. Scope release hands off owned directories after the provider process closes. Pending directories survive restart, live siblings are excluded, and failed deletion retries periodically. Old runtime roots are moved into the queue. Cleanup retains the provider’s Node selection and environment so standalone installs and version-manager shims work too.

Scope and approval

This is a focused fix of the existing resource-lifetime defect in #23877: cleanup must not discard a completed result or monopolize request-serving filesystem workers. The driver, install validator and startup sweep are three paths into that same defect. It is submitted under the focused obvious-bug exception in CONTRIBUTING.md; no maintainer implementation approval is claimed.

Verification

The deadline regressions fail against the base production modules with simulated four-minute title cleanup and two-minute validation cleanup. With this change, both operations return while cleanup is held. vp run check:changed and all 101 focused local tests pass, covering backpressure, live siblings, scheduled retry, shutdown/restart recovery, provider-only Node paths and environment-dependent runtimes.

• Windows QA: windows-2025, Node 26.12.1, 58 tests pass and one existing platform skip. Google’s pinned Antigravity 1.3.0 activates with 9,291 extraction entries still awaiting cleanup. Parent async file reads respond while cleanup is held. Releasing cleanup empties the queue; the longest retained path is 227 characters.
• Installed desktop executable: ran the current checkout’s services under the signed Nightly executable in Node mode (Electron 44.9.3, Node 24.22.0, macOS arm64), with a disposable home and Google’s real 1.3.0 runtime. Fresh installation, existing-release validation, cancellation during native validation, and unauthenticated title generation all finish while cleanup is held. The title reports sign-in required, not timeout. Validator processes exit, the active release is preserved, parent reads respond, and all four cleanup jobs finish with no pending directories or parent recursive unpack deletion.
• Native standalone probes: built real Node 26.12.1 single-executable applications containing the current cleanup service. Verified isSea() === true, separate external-Node cleanup, responsive parent reads while its child is held, and an empty queue after release. A second probe with Node available only through a provider-specific PATH and requiring that provider’s HOME clears eight old directories and admits new work.

Standalone runtime transcript

actual SEA: true host Node: v26.12.1
cleanup runs in a separate Node executable: true
runtime scope released; cleanup child held: true
parent async readFile during held cleanup: responsive
cleanup workers: 1 parent recursive unpack deletes: 0
pending directories after release: 0

Remaining gaps: successful signed-in Google title generation needs an account/API key, neither available here. The reporter’s Windows 11 desktop/ESET environment remains untested; its endpoint protection cause and deletion rate are unconfirmed. The standalone checks exercise the cleanup service in real SEA binaries, rather than a complete packaged CLI. Full upstream test CI is not reported on this PR yet; current GitHub checks cover metadata and review.

Important

Eight pending completed directories stop additional extractions until cleanup catches up. Already-live sessions can still finish, so this bounds new work rather than imposing an absolute disk quota.

Fixes #23877.

Written with GPT-6.1 Sol in the Codex harness, running in T3 Code.

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: e762f09
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: ace4b8eb-6521-4296-b603-bbd69882eb43

Commits

Reviewing files that changed from the base of the PR and between f5f802d and 562f363.

Files selected for processing: 8

• apps/server/scripts/acp-mock-agent.ts
• apps/server/src/provider/AntigravityInstallation.test.ts
• apps/server/src/provider/AntigravityInstallation.ts
• apps/server/src/provider/AntigravityRuntimeTemp.test.ts
• apps/server/src/provider/AntigravityRuntimeTemp.ts
• apps/server/src/provider/Drivers/AntigravityDriver.test.ts
• apps/server/src/provider/Drivers/AntigravityDriver.ts
• apps/server/src/provider/acp/AntigravitySessionFiles.ts

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 66ee628
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: fe25e645-d775-41b0-8bee-30e0666710ec

📥 Commits

Reviewing files that changed from the base of the PR and between 66ee628 and bcbc927.

📒 Files selected for processing: 8

• apps/server/scripts/acp-mock-agent.ts
• apps/server/src/provider/AntigravityInstallation.test.ts
• apps/server/src/provider/AntigravityInstallation.ts
• apps/server/src/provider/AntigravityRuntimeTemp.test.ts
• apps/server/src/provider/AntigravityRuntimeTemp.ts
• apps/server/src/provider/Drivers/AntigravityDriver.test.ts
• apps/server/src/provider/Drivers/AntigravityDriver.ts
• apps/server/src/provider/acp/AntigravitySessionFiles.ts

💤 Files with no reviewable changes: 1

• apps/server/src/provider/acp/AntigravitySessionFiles.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

Antigravity temporary-directory cleanup now runs through a scoped service that queues and retries removal in a background worker. The Antigravity driver and installer use the service. The mock agent also accepts a session ID from its environment.

Changes: Antigravity temporary-directory lifecycle

Layer / File(s)	Summary
Managed temporary-directory lifecycle apps/server/src/provider/AntigravityRuntimeTemp.ts, apps/server/src/provider/AntigravityRuntimeTemp.test.ts	The new service allocates and adopts directories, limits the pending queue to eight, and runs cleanup in a background worker. Tests cover provider environment propagation, backlog handling, retries, and shutdown recovery.
Driver runtime directory management apps/server/src/provider/Drivers/AntigravityDriver.ts, apps/server/src/provider/Drivers/AntigravityDriver.test.ts, apps/server/src/provider/acp/AntigravitySessionFiles.ts	The driver adopts existing directories and obtains managed directories for new runtimes. Tests cover delayed cleanup and cleanup draining. The direct-removal helper is removed.
Installation validation directories apps/server/src/provider/AntigravityInstallation.ts, apps/server/src/provider/AntigravityInstallation.test.ts	Installation validation obtains profile directories from the service and maps backlog-full errors to an installation error. Tests check installation resolution and validator process completion while cleanup is delayed.

Mock agent session ID

Layer / File(s)	Summary
Configurable mock session ID apps/server/scripts/acp-mock-agent.ts	The mock agent uses T3_ACP_SESSION_ID when set and retains "mock-session-1" as its fallback.

Priority: High

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: High

Suggested labels: bugfix

Suggested reviewers: maria-rcks, mweinbach

Merge Risk: Minimal · up to bcbc9

This change moves Antigravity runtime cleanup into a background process so title generation and install validation are no longer delayed by large directory deletions. No actionable merge-blocking issue was found in the supplied changes.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(server): isolate Antigravity runtime cleanup" matches the main change. The PR moves recursive runtime-directory deletion into a separate cleanup subprocess, off the shared filesystem po…
Linked Issues check		The PR addresses the active coding requirements in #23877. AntigravityRuntimeTemp stores pending run-* directories under the state directory and removes them in a separate Node child with synchron…
Out of Scope Changes check		The changes stay within #23877. The runtime service, driver integration, installation integration, session-file cleanup removal, and related test-harness changes all support isolated Antigravity runti…
Description check		The pull request description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the defect, the implementation, the focused-bug approval exception, test…

Full details: Title check

Explanation

The title "fix(server): isolate Antigravity runtime cleanup" matches the main change. The PR moves recursive runtime-directory deletion into a separate cleanup subprocess, off the shared filesystem pool and out of the generation and validation deadlines. The title is concise, follows conventional commit form, and names the server component and the core fix.

Full details: Linked Issues check

Explanation

The PR addresses the active coding requirements in #23877. AntigravityRuntimeTemp stores pending run-* directories under the state directory and removes them in a separate Node child with synchronous, sequential fs.rmSync calls. This avoids the server filesystem pool and keeps recursive deletion outside generation and validation deadlines. AntigravityDriver adopts old directories, creates managed directories, and releases ownership after the provider runtime closes. The cleanup worker excludes active siblings, persists pending directories across restart, retries failed work, and limits the backlog. AntigravityInstallation uses the same service for validation cleanup and preserves the provider Node environment. The supplied focused tests cover deadline behavior, backpressure, live siblings, retry, restart recovery, and provider-specific runtimes.

Full details: Out of Scope Changes check

Explanation

The changes stay within #23877. The runtime service, driver integration, installation integration, session-file cleanup removal, and related test-harness changes all support isolated Antigravity runtime cleanup or its verification. The mock session ID change supports deterministic ACP test setup. The supplied change summary identifies no unrelated product behavior or unrelated files.

Full details: Description check

Explanation

The pull request description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the defect, the implementation, the focused-bug approval exception, test results, platform checks, remaining gaps, and agent attribution.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @Zheruel. the separate cleanup process correctly keeps recursive deletion outside request deadlines and the server filesystem pool.

updated the existing branch to 562f36350013aa19602f228ab3807adfccb88bf3:

• merged current main, preserving your commits and resolving comment-only conflicts around the removed cleanup code.
• replaced the inline backlog schema predicate with its error tag to satisfy current lint. kept the cleanup design and regression coverage intact; no new test files.
• reviewed allocation, active siblings, process teardown, retry, shutdown/restart, and shared service wiring. two independent lifecycle/correctness reviews approve this head with no findings.

verification through blacksmith:

• against main e762f09e265b, both deadline regressions fail: completed title generation times out; validated installation reports failed.
• with this head, vp run check:changed passes format, lint, both knip passes, graphql generation, affected typechecks, and all 38 tests across the driver, installer, and cleanup service. these exercise actual child processes with a mock ACP provider, including held cleanup and nearby refresh/sign-in failure paths.

unverified this run: signed-in native google generation, native antigravity installation, packaged electron/standalone, windows/macOS, and client UI. no native provider/account is available on this linux VM. this is a server lifecycle change; no UI code changed. all seven reported check contexts are green and gitcafe reports mergeable. full github CI has not run: CI and the other fork workflows report action_required and need maintainer approval. coderabbit reports success but skipped this head due its review quota; both independent reviews approved the final head. no bot findings remain to address.