Repository navigation
#221: Fix missing list markers in chat markdown - #224
Merged
Merged
Conversation
Tailwind v4 Preflight resets list-style to none on ul/ol elements. Restore disc/decimal markers and add nested list style variants (circle, square, lower-alpha, lower-roman) for visual distinction.
|
@JoeEverest is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores visible list markers in chat-rendered Markdown after Tailwind v4 Preflight removed default ul/ol list styling, and adds distinct marker styles for nested lists to improve readability in chat transcripts.
Changes:
- Add explicit
list-style-typeandpadding-leftfor.chat-markdown uland.chat-markdown ol. - Add nested list marker variants for deeper
ul/ollevels (circle/square and lower-alpha/lower-roman).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Good fix ty |
youpele52
referenced
this pull request
in youpele52/bigbud
Jun 17, 2026
Tailwind v4 Preflight resets list-style to none on ul/ol elements. Restore disc/decimal markers and add nested list style variants (circle, square, lower-alpha, lower-roman) for visual distinction.
dcherrera
pushed a commit
to dcherrera/t3code
that referenced
this pull request
Jul 7, 2026
Tailwind v4 Preflight resets list-style to none on ul/ol elements. Restore disc/decimal markers and add nested list style variants (circle, square, lower-alpha, lower-roman) for visual distinction.
NeilTheFisher
pushed a commit
to NeilTheFisher/t3code
that referenced
this pull request
Aug 18, 2026
Tailwind v4 Preflight resets list-style to none on ul/ol elements. Restore disc/decimal markers and add nested list style variants (circle, square, lower-alpha, lower-roman) for visual distinction.
aorwall
added a commit
to aorwall/t3code
that referenced
this pull request
Oct 12, 2026
Merges `pingdotgg/t3code` `aacefcd7e9` (101 commits since `c9fa1367ca`) into the fork. It branches from `main`; no other merge PR is open. Opened as a **draft** because one verification failure has no fix here: `apps/server` typecheck reports `TS377030` (`anyUnknownInErrorContext`) at every `runCli` in `src/cli/app.test.ts`, `project.test.ts` and `theme.test.ts`. Upstream's own `apps/server` tree, checked out over this one, reports the same errors, and the fork has no delta in those files or the server's config. When the requirements type is probed directly it comes out as `never`. This is recorded in `docs/fork/gaps.md`. Someone needs to confirm whether upstream CI is red on this too, or whether something in the fork's toolchain causes it. ## Conflicts (9) - `apps/server/src/cli/pair.test.ts`: still deleted (the fork removed pairing). - `apps/web/package.json`: kept `@t3tools/moatless-api` next to upstream's `@t3tools/provider-acp-registry`. - `ChatView.tsx`: kept upstream's child-question banner (pingdotgg#16634) and the fork's sandbox-commands banner. - `RightPanelTabs.tsx`: kept both import blocks. - `DraftHeroHeadline.tsx`: upstream rebuilt the project picker as a searchable Combobox (pingdotgg#17664), so the old inventory entry no longer applied. The `FEATURES.projectManagement` gate now sits where `pickerItems` is built, and the inventory entry is rewritten to match. - `SidebarChrome.tsx`: upstream only restyled the brand row (pingdotgg#16134), so the fork's Moatless name span stays. - `textarea.tsx`: took upstream's `ring-inset` and kept the fork's `font="mono"` prop. - `threadShell.ts`: upstream now imports `isProviderNativeSubagentThread` itself. Took its import line; the fork's filter is unchanged. - `pnpm-lock.yaml`: started from upstream's copy and regenerated it with an install. The committed lockfile includes the fork's own dependencies (`moatless-api`). Other changes: - `SectionSearch.tsx`: added `ring-inset` to satisfy upstream's new `no-outset-state-indicators` lint rule (pingdotgg#16675). - `rpc.ts`: `UnsupportedMethodError` is now on `server.getStorageCleanupReport` and `server.runStorageCleanup`. ## Verification - Checks: duplicate-adds, tripwires, resolution-check, unsupported-methods, lockfile, fmt, lint and the production build all pass. `typecheck` fails as described above. - Tests: four failures that also fail when run alone. The same four failed on the 2026-10-08 and 2026-10-09 merges, and all come from the sandbox: - `ServerBrowserPage`: the Playwright browser isn't installed. - `OrchestratorReplayFixtures`: the sandbox's `CLAUDE_CONFIG_DIR` leaks into an expected error message. - `AcpAdapterV2` and `OpenCodeServerLedger`: the sandbox doesn't reap process groups. - File counts: 929 files landed against 927 changed upstream. The fork side adds the gaps register, the inventory and `SectionSearch.tsx`; the deleted `pair.test.ts` accounts for the other side. The fork delta is unchanged at 775 files. ## Feature classification ### Usable as-is - The draft screen's project picker is searchable (pingdotgg#17664). - Breadcrumb navigation to a thread's parent (pingdotgg#16666). - A keyboard shortcut for the thread details panel (pingdotgg#16694). - Pending requests wait until you stop typing (pingdotgg#17637). - A pending subagent question shows on its parent thread (pingdotgg#16634). Moatless child tasks would show their questions on the parent, which is probably what we want. - Many resize, focus-ring and layout fixes (pingdotgg#17656–pingdotgg#17660, pingdotgg#16675, pingdotgg#17383, pingdotgg#17534, and others). ### Unsupported in Moatless / needs implementation - **Storage cleanup report and run** (pingdotgg#17563, `StorageSettings.tsx`): `server.getStorageCleanupReport` and `server.runStorageCleanup`. The controls only appear when the server advertises `capabilities.storageCleanup` / `storageCleanupRun`, which Moatless doesn't, so this PR adds only the two union entries and no gate. - **PR comment filters for bots and resolved threads** (pingdotgg#17645): these live behind the `pullRequestSurface` gate, which is off. - Desktop-only features: T3 Code as the default macOS browser (pingdotgg#17587) and passkeys in the in-app browser (pingdotgg#16952). - T3 Connect and relay fixes (pingdotgg#17366, pingdotgg#17599, pingdotgg#17602, pingdotgg#17158): not used here. ### Backend behavior to consider reproducing in Moatless - A snoozed thread's inactivity clock restarts when it wakes (pingdotgg#16674). - Pulls and rebases during a turn no longer flood its changed-files list (pingdotgg#17161). - A PR can be opened from a dirty worktree (pingdotgg#15625). - The Claude MCP token is kept out of process arguments (pingdotgg#17408). - A logged-out Claude CLI no longer reports as authenticated (pingdotgg#15459). - Passive terminal output keeps flowing (pingdotgg#17178). - The preview browser stays connected after operation timeouts (pingdotgg#17693), and the preview probe only checks listeners it owns (pingdotgg#16687). The `docs/fork/gaps.md` sections for unsupported methods, settlement rules and runtime fixes are extended to cover these, and the tracker has a new entry in `docs/fork/upstream-merge-log.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/478f99c2-3125-4e8a-b243-4f30de5f6819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tailwind v4 Preflight resets list-style to none on ul/ol elements. Restore disc/decimal markers and add nested list style variants (circle, square, lower-alpha, lower-roman) for visual distinction.