Skip to content

fix(web): give PR row metadata room below the title - #21165

Open
Aforno wants to merge 2 commits into
pingdotgg:mainfrom
Aforno:fix/thread-details-pr-spacing
Open

Aforno wants to merge 2 commits into
pingdotgg:mainfrom
Aforno:fix/thread-details-pr-spacing

Conversation

@Aforno

@Aforno Aforno commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

The thread details card pulled PR metadata into the title row, crowding checks and watch controls. Remove the negative top margin so metadata begins below the title, preserving full-width titles, indentation and spacing between PRs. The same component renders the main PR and expanded linked PR rows in web and desktop.

Retains the focused fix by @Aforno in #21165, with the pinned main revision merged while preserving the original commits.

Validation: changed-file lint and diff whitespace checks passed. Independent Opus and Sol reviews found no code blockers. No tests were added for the spacing-only change; existing row behavior tests are unchanged.

Verified in the actual integrated web app at 1280×800 with two linked public PRs, comparing base 952921f39a with head 991c2ea1f7. Both main and expanded rows had 4px of overlap before; each metadata row starts at the title's bottom edge after. The layout remains compact, titles retain full width, and the checks popover opens and dismisses. Native Electron was not exercised separately; it uses the shared renderer.

Before: metadata overlaps title After: metadata sits below title
Before: 4px overlap in main and expanded PR rows After: overlap removed in both PR rows

Current-head CI runs after this update; earlier checks cover the original head only.

Implementation assessment: Claude Fable 5.1. Test assessment and independent reviews: Claude Opus 5.5 and GPT-6.1 Sol. Coordination: GPT-6.1 Sol through the Codex harness in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 18, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d7190fb

Macroscope's review found this PR approvable — This one-line web UI adjustment removes a negative top margin from the PR metadata row, giving the existing title and metadata controls normal vertical separation without changing data or interaction logic. It is a small, self-contained visual bug fix with no new capability or configuration impact.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge self-assigned this Oct 18, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Taking over this one. I’ll reduce the tests to the useful coverage, update the implementation against current main, and verify it before publishing the changes.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41121127-e440-49b3-bdc2-cab19ef87f5f
📥 Commits

Reviewing files that changed from the base of the PR and between 952921f and 991c2ea.

📒 Files selected for processing: 1
  • apps/web/src/components/chat/ThreadDetailsPrRow.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The pull-request metadata row no longer uses a negative top margin. Its remaining layout classes are unchanged.

Changes: Pull-request metadata spacing

Layer / File(s) Summary
Metadata row spacing
apps/web/src/components/chat/ThreadDetailsPrRow.tsx
The pull-request metadata row no longer uses the -mt-1 class. Other layout classes remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 991c2

The change adds space above PR metadata, with no identified behavior issue. It appears mergeable subject to normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly describes the main change: adding space below PR row metadata in the web UI. It is concise and uses a conventional commit format.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification information. It explains the focused fix, links the related PR, documents manual UI verification, includes b…
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification information. It explains the focused fix, links the related PR, documents manual UI verification, includes before-and-after screenshots, and states unverified areas.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants