Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-line web UI adjustment removes a negative top margin from the PR metadata row, giving the existing title and metadata controls normal vertical separation without changing data or interaction logic. It is a small, self-contained visual bug fix with no new capability or configuration impact. You can add or adjust custom eligibility rules. Learn more. |
Member
|
Taking over this one. I’ll reduce the tests to the useful coverage, update the implementation against current main, and verify it before publishing the changes. |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread details card pulled PR metadata into the title row, crowding checks and watch controls. Remove the negative top margin so metadata begins below the title, preserving full-width titles, indentation and spacing between PRs. The same component renders the main PR and expanded linked PR rows in web and desktop.
Retains the focused fix by @Aforno in #21165, with the pinned main revision merged while preserving the original commits.
Validation: changed-file lint and diff whitespace checks passed. Independent Opus and Sol reviews found no code blockers. No tests were added for the spacing-only change; existing row behavior tests are unchanged.
Verified in the actual integrated web app at 1280×800 with two linked public PRs, comparing base 952921f39a with head 991c2ea1f7. Both main and expanded rows had 4px of overlap before; each metadata row starts at the title's bottom edge after. The layout remains compact, titles retain full width, and the checks popover opens and dismisses. Native Electron was not exercised separately; it uses the shared renderer.
Current-head CI runs after this update; earlier checks cover the original head only.
Implementation assessment: Claude Fable 5.1. Test assessment and independent reviews: Claude Opus 5.5 and GPT-6.1 Sol. Coordination: GPT-6.1 Sol through the Codex harness in T3 Code.