Skip to content

fix(mobile): read-only thread rows keep their side inset - #19944

Closed
ipanasenko wants to merge 2 commits into
pingdotgg:mainfrom
ipanasenko:fix/mobile-padding
Closed

ipanasenko wants to merge 2 commits into
pingdotgg:mainfrom
ipanasenko:fix/mobile-padding

Conversation

@ipanasenko

@ipanasenko ipanasenko commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

On Android, a thread row gets its 8dp side inset from the swipe wrapper's container style. A row whose environment session lacks operate scope (for example, while that environment reconnects) skipped the wrapper and lost the inset. Those rows sat closer to the screen edge than rows from connected environments.

image
 <ThreadListV2Row>
-  if (!canOperateThread) rowContent
+  if (!canOperateThread)
+    <View style={swipeContainerStyle}>   # same insets as ThreadSwipeable
+      rowContent
   <ThreadSwipeable containerStyle={swipeContainerStyle}>
     rowContent

ArchivedThreadsScreen already wraps its read-only rows this way.

Evidence

  • Before: On Android, with one environment reconnecting, its rows start about 8dp further left than rows from a connected environment.
    After: Wasn't able to check on a device. apps/mobile typecheck passes. thread-list-v2-row-appearance.test.ts passes (12/12).

Merge Danger

Door: two-way

Blast Radius: Small

Layout only. Android read-only rows get the same inset, vertical margin, and rounded clip as operable rows. iOS home rows get an undefined style (no change). iOS sidebar read-only rows now clip to the 12pt corner radius, the same as operable rows.


Made with Claude Opus 5.5 in T3 Code (Claude Code harness).

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 15, 2026
@ipanasenko
ipanasenko marked this pull request as ready for review October 15, 2026 16:59
@macroscopeapp

macroscopeapp Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5bc5fda

Macroscope's review found this PR approvable — This one-file mobile UI fix preserves read-only behavior while restoring the established container insets and clipping, with no schema, infrastructure, security, billing, or static-analysis impact. The runtime scope is limited to row presentation.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b94dabd0-570c-4da2-ae8b-733dfea80150
📥 Commits

Reviewing files that changed from the base of the PR and between 5bc5fda and 8c78841.

📒 Files selected for processing: 1
  • apps/mobile/src/features/threads/thread-list-v2-items.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Read-only thread rows now render inside a View styled with rowAppearance.swipeContainerStyle. The row still omits the swipe layer.

Changes: Thread rows

Layer / File(s) Summary
Read-only row container
apps/mobile/src/features/threads/thread-list-v2-items.tsx
The read-only row path wraps the row content in a View styled with rowAppearance.swipeContainerStyle.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 8c788

Read-only rows receive the intended container styling without an established regression; the change is ready to merge subject to normal checks.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem, implementation, scope, and available verification. It does not provide the required scope and approval evidence, and it lacks clear before-and-after screenshots f… Add a link to the triaged issue or maintainer approval, or explain why this focused bug fix qualifies without prior approval. Add clear before-and-after screenshots, or state the limitation and provide the strongest available visual verific…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: preserving the side inset for read-only mobile thread rows.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, implementation, scope, and available verification. It does not provide the required scope and approval evidence, and it lacks clear before-and-after screenshots for the UI change.

Resolution

Add a link to the triaged issue or maintainer approval, or explain why this focused bug fix qualifies without prior approval. Add clear before-and-after screenshots, or state the limitation and provide the strongest available visual verification.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@t3dotgg

t3dotgg commented Oct 18, 2026

Copy link
Copy Markdown
Member

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

Closing: #21071 shipped this same change. Rows that cannot be operated are now wrapped in rowAppearance.swipeContainerStyle in thread-list-v2-items.tsx, so they line up with swipeable rows. Thanks for catching it.

@t3dotgg t3dotgg closed this Oct 18, 2026
@ipanasenko
ipanasenko deleted the fix/mobile-padding branch October 18, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants