Repository navigation
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a five-line, single-component layout fix that reuses the existing swipe-container styling for rows without swipe actions. Its runtime impact is limited to consistent insets and corner treatment, with no changes to thread behavior, data, defaults, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description includes all required sections. It explains the layout problem, the code change, the scope rationale, verification steps, observed results, screenshots, and unverified platforms. |
| Title check | |
The title clearly and concisely describes the primary fix: aligning thread rows that do not have swipe actions. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
A thread row skips its swipe wrapper when the client has no operate grant for the row's environment, which is the case for an environment not reached in the current app session. The wrapper also carried the row's container inset, so those rows sat 8dp further out than their neighbours on Android and in the iPad sidebar. They now keep the same container style.
acd9c6c to
2ea681e
Compare
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo Closing: #21071 shipped this same change. Rows that cannot be operated are now wrapped in |
2 participants
Problem
On Android, and in the iPad sidebar, thread rows of an environment the app has not reached in the current session sit 8dp further out on both sides than their neighbours. With two environments, one connected and one not, the list has two different left edges, and the time label and provider icon on the right are offset too.
Change
A thread row skips its swipe wrapper when the client has no operate grant for the row's environment (
thread-list-v2-items.tsx). The wrapper is also what applied the row's container style (swipeContainerStyle: an 8dp horizontal margin, 2dp vertical margin, and corner radius on Android; the sidebar container on iOS), so those rows lost it. They are now wrapped in a plain view carrying the same container style.The iPhone list has no container style, so nothing changes there.
Scope and approval
A very small, focused fix for an obvious layout bug: one branch of one component, five added lines, no behaviour change. Rows in the same list should share an edge whether or not they can be swiped. No prior issue.
Verification
Android 17 emulator (Pixel 9), mobile dev client, two saved environments: "homelab" is connected, "laptop" is not reachable, so the app holds no operate grant for it. Before is main at 511d20c; after is this branch. Same device, same data.
Before, the two laptop rows start further left than the homelab row and their time labels and provider icons sit further right. After, all three rows line up.
The mobile typecheck passes. No test added: the fix is a layout wrapper, and a test for it would only assert the style prop.
Not checked: the iPad sidebar and iOS in general. The sidebar takes the same code path with its own container style, but only the Android phone list was run.
Claude Opus 5.5 in Claude Code, running in T3 Code.