Repository navigation
fix(web): make hosted clients installable on Android - #18269
mynameistito wants to merge 4 commits into
Conversation
github-actions
Bot
added
vouch:unvouched
|
Note This comment is posted by Julius' dot The manifest and icon checks don't show that Android Chrome installs and launches this change without the browser header. #17781 supplies a before screenshot, but this PR has no after screenshot or installation/launch recording. Closing under the verification requirement. Check the changed build in Android Chrome, attach the after screenshot and a short recording showing installation and standalone launch, and request reconsideration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the main change: making hosted web clients installable on Android. |
| Description check | |
The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the issue, implementation, scope exception, manual Android Chrome verification, before… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the issue, implementation, scope exception, manual Android Chrome verification, before-and-after videos, and formatting check.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Hey @juliusmarminge, sorry about the delay, everything is now updated with relevant videos of before and after states, tested locally with cloudflared. |
|
Closing as it seems to be fixed on one of the nightly releases since making this PR. |
|
oh disregard lol, it didn't show up due to my phone not having Tailscale on* reopened. |
|
Note Grok responding on behalf of Julius. Closing as superseded by #19175, which landed a narrower fix for #17781: adding |
Problem
Issue #17781 reports that Android Chrome launches the hosted Nightly client with its browser header instead of as a standalone app. The manifest already asks for
standalonedisplay, but it lacks an app name and the 192×192 and 512×512 icons Chrome needs to offer an installable web app.Change
Add the manifest name and short name, plus branded 192px and 512px icons. Extend the existing icon export and copy paths so development, Nightly, and production builds all provide the assets. Update the install guide to distinguish Android Chrome's Install app option from a home-screen shortcut. A service worker isn't needed for this installability fix.
Scope and approval
This addresses the single installability bug in #17781. The asset-pipeline changes are needed to serve the manifest's icons across the existing build brands; there are no changes to native Android distribution or offline behavior. I found no explicit maintainer approval, so this relies on the focused, obvious bug-fix exception in CONTRIBUTING.md. Maskable artwork and channel-specific install identities are outside this change.
Verification
pnpm exec vp run dev, exposed the web app through a Cloudflare Quick Tunnel, and checked the install/launch behavior in Android Chrome.t3code-18269-before.mp4
Home-screen shortcut retains the browser header.
t3-code-18269-after.mp4
Installed app opens without the browser header.
Tested locally with
cloudflared.vp fmt --checkreported the changed files are formatted.Created with GPT-6 Luna in the OpenCode harness.