Skip to content

fix(web): Local environment switch stays reachable after turning it off - #17359

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
ScottN-PV:fix/17013-local-env-toggle
Oct 9, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
ScottN-PV:fix/17013-local-env-toggle

Conversation

@ScottN-PV

Copy link
Copy Markdown
Contributor

Problem

On desktop, turning off Local environment in Settings → Connections hides the switch that turns it back on. With the local environment off there is no primary environment, so the "This machine" card shows only "No environment selected", and the Settings search result for "Local environment" lands on the same empty card. The issue's workaround uses DevTools.

Change

ConnectionsSettings now renders LocalEnvironmentSetting in the "No environment selected" branch as well. The component returns nothing without the desktop bridge, so browser and hosted builds are unchanged.

Scope and approval

Closes #17013. The triage comment confirms the cause on main and suggests this fix. The branch condition changed in #9786.

Verification

An agent ran these checks. No person tested the change.

Desktop dev app (vp run dev:desktop) on Windows 11, isolated state, localEnvironmentEnabled: false, no remote environments:

Before (main) After
Before: This machine card shows only No environment selected After: the card also shows the Local environment switch, off

Turning the switch on and confirming Restart and turn on relaunches the app with the local environment running, and Connections shows the machine card again (hostname covered):

recovery.mp4

Web tsc --noEmit passes. vp lint and vp fmt --check on the changed file pass. No unit test: the change adds one element to an existing branch, and a test would only assert component structure, which AGENTS.md asks us not to do. The desktop run above is the regression check. Not checked: macOS and Linux desktop builds, and the reporter's setup with a remote environment connected. The primary environment id is null in that setup too, so the same branch renders.

Model: Claude Opus 5.5, Claude Fable 5.1 (review), GPT-6-Astra (review). Harness: Claude Code, Codex.

With the local environment off there is no primary environment, so the
Connections section rendered only "No environment selected" and the
switch to turn it back on disappeared.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 8, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 15dd720

Macroscope's review found this PR approvable — This localized UI fix keeps the existing local-environment switch visible after the local environment is disabled, without changing the toggle logic or other runtime paths. It introduces no schema, deployment, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7e073d16-0d06-41b2-afa7-8ead9c3b7df9
📥 Commits

Reviewing files that changed from the base of the PR and between d81afa0 and 15dd720.

📒 Files selected for processing (1)
  • apps/web/src/components/settings/ConnectionsSettings.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

When no primary environment is selected, Connections settings now renders LocalEnvironmentSetting below the “No environment selected” row. The conditional T3 Connect row remains unchanged.

Changes

Connections settings

Layer / File(s) Summary
Show local environment control in fallback
apps/web/src/components/settings/ConnectionsSettings.tsx
The no-environment-selected section now renders LocalEnvironmentSetting beneath its message row.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 15dd7

The change makes the local-environment switch available in the no-environment settings view. No concrete merge-blocking behavior is identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 15dd7

The switch remains desktop-only and requires explicit confirmation. No new privilege or authorization bypass was identified. Recovery from an interrupted restart is not fully established, so the assessment retains limited uncertainty.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The changed interaction targets the current desktop installation’s persisted local-execution setting and restart lifecycle. It supplies no remote environment, tenant, credential, or arbitrary setting identifier to the privileged operation.

Trust Boundaries and Controls

  • inferred — The new rendering location does not expand the desktop renderer’s existing IPC authority. Startup installs IPC handlers before the disabled-backend branch, and the preload already exposes the setter. UI confirmation is an interaction safeguard, not a new authorization boundary.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title is concise, uses the repository's conventional format, and clearly describes the primary fix: keeping the Local environment switch reachable after it is disabled.
Description check Passed The description includes all required sections. It explains the problem, change, scope and approval, verification results, screenshots, limitations, and agent details.
Linked Issues check Passed Issue #17013 requires the Local environment switch to remain visible in the desktop Connections settings after the local environment is disabled. The PR adds LocalEnvironmentSetting to the “No environ…
Out of Scope Changes check Passed The reviewed change is limited to adding LocalEnvironmentSetting to the existing fallback branch in apps/web/src/components/settings/ConnectionsSettings.tsx. This directly supports issue #17013 and do…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit 2cf0ff0 into pingdotgg:main Oct 9, 2026
29 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 9, 2026
## What's Changed
* fix(web): Local environment switch stays reachable after turning it off by @ScottN-PV in pingdotgg/t3code#17359
* fix(web): keep chat banners inside the lane beside the docked details card by @macodev00 in pingdotgg/t3code#17094
* fix(web): settled and snoozed lines line up with the messages above them by @RakshithBhat03 in pingdotgg/t3code#17191
* fix(web): distinguish project filter from new project by @voltcrash in pingdotgg/t3code#12113
* feat(web): assign a thread details panel shortcut by @maria-rcks in pingdotgg/t3code#16694
* fix(web): chat content keeps pace with sidebar resizing by @flamboh in pingdotgg/t3code#17383
* refactor(provider-core): expose model metadata through a ModelCatalog port by @juliusmarminge in pingdotgg/t3code#17417
* refactor(provider-core): follow the Effect service conventions throughout by @juliusmarminge in pingdotgg/t3code#17427
* refactor(provider-core): latest-version lookups go through a ProviderLatestVersions service by @juliusmarminge in pingdotgg/t3code#17434
* refactor(provider-core): MCP provider sessions live in a McpProviderSessions service by @juliusmarminge in pingdotgg/t3code#17446
* refactor(provider): bring opencode, muse, pi, core and testing in line with Effect conventions by @juliusmarminge in pingdotgg/t3code#17542
* refactor(provider-acp): ACP, ACP Registry and Grok follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17544
* refactor(provider-cursor): follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17545
* fix(marketing): use app wordmark in header by @voltcrash in pingdotgg/t3code#13240
* fix(web): pr merge actions stay visible while the stack refreshes by @maria-rcks in pingdotgg/t3code#17559

## New Contributors
* @voltcrash made their first contribution in pingdotgg/t3code#12113

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2873...v0.0.46-nightly.20261009.2886

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261009.2886
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 9, 2026
## What's Changed
* fix(web): Local environment switch stays reachable after turning it off by @ScottN-PV in pingdotgg/t3code#17359
* fix(web): keep chat banners inside the lane beside the docked details card by @macodev00 in pingdotgg/t3code#17094
* fix(web): settled and snoozed lines line up with the messages above them by @RakshithBhat03 in pingdotgg/t3code#17191
* fix(web): distinguish project filter from new project by @voltcrash in pingdotgg/t3code#12113
* feat(web): assign a thread details panel shortcut by @maria-rcks in pingdotgg/t3code#16694
* fix(web): chat content keeps pace with sidebar resizing by @flamboh in pingdotgg/t3code#17383
* refactor(provider-core): expose model metadata through a ModelCatalog port by @juliusmarminge in pingdotgg/t3code#17417
* refactor(provider-core): follow the Effect service conventions throughout by @juliusmarminge in pingdotgg/t3code#17427
* refactor(provider-core): latest-version lookups go through a ProviderLatestVersions service by @juliusmarminge in pingdotgg/t3code#17434
* refactor(provider-core): MCP provider sessions live in a McpProviderSessions service by @juliusmarminge in pingdotgg/t3code#17446
* refactor(provider): bring opencode, muse, pi, core and testing in line with Effect conventions by @juliusmarminge in pingdotgg/t3code#17542
* refactor(provider-acp): ACP, ACP Registry and Grok follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17544
* refactor(provider-cursor): follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17545
* fix(marketing): use app wordmark in header by @voltcrash in pingdotgg/t3code#13240
* fix(web): pr merge actions stay visible while the stack refreshes by @maria-rcks in pingdotgg/t3code#17559

## New Contributors
* @voltcrash made their first contribution in pingdotgg/t3code#12113

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2873...v0.0.46-nightly.20261009.2886

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261009.2886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Local environment can't be turned back on once disabled (toggle hidden behind "No environment selected")

2 participants