Skip to content

fix(web): context menus no longer scroll when they fit the window #16776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Oct 12, 2026
Merged

fix(web): context menus no longer scroll when they fit the window #16776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e6e34
fix(web): fit context menus to viewport height
kacigaya Oct 7, 2026
de158d8
Merge branch 'main' into fix/thread-menu-no-scroll
kacigaya Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/web/src/contextMenuFallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,12 @@ export function showContextMenuFallback<T extends string>(
menu.dataset.level = String(level);

const inner = document.createElement("div");
// Fit the viewport (minus clampMenuPosition's 4px margins) so menus only
// scroll when the window is shorter than the menu itself.
inner.className =
"max-h-[min(24rem,70vh)] min-w-0 max-w-sm overflow-y-auto overflow-x-hidden p-1";
"max-h-[calc(100vh-0.5rem)] min-w-0 max-w-sm overflow-y-auto overflow-x-hidden p-1";
inner.style.cssText =
"max-height:min(24rem,70vh);min-width:0;max-width:24rem;overflow-x:hidden;overflow-y:auto;padding:0.25rem;";
"max-height:calc(100vh - 0.5rem);min-width:0;max-width:24rem;overflow-x:hidden;overflow-y:auto;padding:0.25rem;";

for (const item of entries) {
if (item.separatorBefore === true && inner.children.length > 0) {
Expand Down
Loading