Skip to content

fix: restore service references breaking ci #16495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 3 commits into from
Oct 6, 2026
Merged

fix: restore service references breaking ci #16495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feed432
fix(desktop): restore screenshot crypto service lookup
maria-rcks Oct 6, 2026
4aa8fd3
test(desktop): provide crypto to preview manager checks
maria-rcks Oct 6, 2026
421f7e9
fix(server): use renamed editor launcher test layer
maria-rcks Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/desktop/src/preview/Manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { it as effectIt } from "@effect/vitest";
import * as NodeCrypto from "@effect/platform-node/NodeCrypto";
import { DESKTOP_PREVIEW_RECORDING_CAPTURE_TRIGGER } from "@t3tools/contracts";
import type {
DesktopPreviewRecordingFrame,
Expand Down Expand Up @@ -281,6 +282,7 @@ const layer = PreviewManager.layer.pipe(
Layer.provideMerge(layerEnvironment),
Layer.provideMerge(layerFileSystem),
Layer.provideMerge(Path.layer),
Layer.provideMerge(NodeCrypto.layer),
Layer.provideMerge(Layer.succeed(HostProcessPlatform, "darwin")),
);

Expand Down
2 changes: 2 additions & 0 deletions apps/desktop/src/preview/Manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
import * as Cause from "effect/Cause";
import * as Clock from "effect/Clock";
import * as Context from "effect/Context";
import * as Crypto from "effect/Crypto";
import * as DateTime from "effect/DateTime";
import * as Deferred from "effect/Deferred";
import * as Effect from "effect/Effect";
Expand Down Expand Up @@ -547,6 +548,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
const rendererHistory = yield* DesktopRendererHistory.DesktopRendererHistory;
const hostPlatform = yield* HostProcessPlatform;
const path = yield* Path.Path;
const crypto = yield* Crypto.Crypto;
const parentScope = yield* Scope.Scope;
const browserHost = yield* DesktopBrowserHost.DesktopBrowserHost;
const context = yield* Effect.context<never>();
Expand Down
6 changes: 3 additions & 3 deletions apps/server/src/process/externalLauncher.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ it.effect.each([
yield* launcher.launchEditor({ editor, cwd: "/workspace with spaces/file.ts:12:4" });
}).pipe(
Effect.provide(
testLayer({
layerTest({
platform: "darwin",
env: { HOME: home, PATH: path.join(home, "empty") },
onSpawn: (command) => {
Expand Down Expand Up @@ -1111,7 +1111,7 @@ it.effect("matches macOS bundles on the name boundary only", () =>
return yield* launcher.resolveAvailableEditors();
}).pipe(
Effect.provide(
testLayer({ platform: "darwin", env: { HOME: home, PATH: path.join(home, "bin") } }),
layerTest({ platform: "darwin", env: { HOME: home, PATH: path.join(home, "bin") } }),
),
);

Expand Down Expand Up @@ -1155,7 +1155,7 @@ it.effect("keeps the macOS VS Code Insiders bundle out of stable VS Code", () =>
return available;
}).pipe(
Effect.provide(
testLayer({
layerTest({
platform: "darwin",
env: { HOME: home, PATH: path.join(home, "empty") },
onSpawn: (command) => {
Expand Down
Loading