Skip to content

chore(review): configure CodeRabbit in TypeScript #16281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Oct 6, 2026
Merged

chore(review): configure CodeRabbit in TypeScript #16281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b5dd0
chore(review): configure CodeRabbit in TypeScript
esthor Oct 5, 2026
3b314ac
chore(review): point CodeRabbit at the Effect services guide
esthor Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .coderabbit.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { defineConfig } from "@coderabbitai/config";

export default defineConfig({
reviews: {
high_level_summary: false,
review_status: false,
auto_review: {
enabled: true,
},
path_filters: [
// Vendored read-only reference checkouts of upstream Effect and Alchemy
// (see scripts/lib/reference-repos.ts). Nothing imports from them.
"!.repos/**",
],
path_instructions: [
{
path: "{apps,packages,infra}/**/*.ts",
instructions: "Hold changed code to the rules in docs/internals/effect-services.md.",

@macroscopeapp macroscopeapp Bot Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium .coderabbit.config.ts:18

The Effect-service guide is applied to every TypeScript file under apps, packages, and infra, including apps/mobile and apps/web, so client changes are reviewed against server-only transport and service-layering rules and receive misleading findings. Restrict both the path_instructions and code_guidelines.filePatterns globs to the server/Effect-service locations.

🤖 Copy this AI Prompt to have your agent fix this: 
In file @.coderabbit.config.ts around line 18:

The Effect-service guide is applied to every TypeScript file under `apps`, `packages`, and `infra`, including `apps/mobile` and `apps/web`, so client changes are reviewed against server-only transport and service-layering rules and receive misleading findings. Restrict both the `path_instructions` and `code_guidelines.filePatterns` globs to the server/Effect-service locations.

@esthor esthor Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this scope. It is the same as the repo's existing Effect Service Conventions check: TypeScript under apps, packages and infra.

Effect services aren't server-only. Desktop, infra and packages define about 110 of them, and web and mobile use Effect in about 290 .ts files, where the import, error and runtime-boundary rules apply. React components (.tsx) aren't matched, and the transport-handler rules apply only where there are handlers.

@macroscopeapp macroscopeapp Bot Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

},
],
},
knowledge_base: {
code_guidelines: {
filePatterns: [
{ files: "docs/internals/effect-services.md", applyTo: "{apps,packages,infra}/**/*.ts" },
],
},
},
});
9 changes: 0 additions & 9 deletions .coderabbit.yaml
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion knip.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
".": {
// Keep vendored reference repositories outside the root project.
"project": ["*.{js,mjs,cjs,ts,mts,cts}", ".github/**/*.cjs"],
"entry": [".github/scripts/thread-transfer-report.cjs"],
"entry": [
// CodeRabbit loads its configuration by filename.
".coderabbit.config.ts",
".github/scripts/thread-transfer-report.cjs",
],
"vite": { "entry": [".github/**/*.test.cjs"] },
"vitest": { "entry": [".github/**/*.test.cjs"] },
},
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"sync:repos": "node scripts/sync-reference-repos.ts"
},
"devDependencies": {
"@coderabbitai/config": "1.1.0",
"@effect/tsgo": "catalog:",
"@shadcn/lint": "0.1.5",
"@types/node": "catalog:",
Expand Down
15 changes: 15 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading