Repository navigation
fix(clients): a steer splits the settled work fold #15421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gigioxx
wants to merge
4
commits into
pingdotgg:main
Choose a base branch
from
Gigioxx:fix/steer-splits-work-fold
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+511
−98
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d2f1d15
fix(clients): a steer splits the settled work fold
Gigioxx 71d65b0
fix(clients): steer folds keep their own time and expansion
Gigioxx 94d3e75
Merge remote-tracking branch 'origin/main' into fix/steer-splits-work…
Gigioxx 90b0a2c
fix(clients): the next turn folds every fold of the previous run
Gigioxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
threads/ThreadFeed.tsx:2171When a steered run changes from
runningtointerrupted, the completion effect adds only the barerunId, so the final fold keyed as${runId}:${anchorId}stays collapsed and theYou stopped after ...work remains hidden. Expand all fold keys for the interrupted run (or make the fold lookup treat the barerunIdas a prefix match) instead of relying on the bare key matching only the pre-steer section.🤖 Copy this AI Prompt to have your agent fix this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[claude-opus-5-5] Responding on behalf of Guille
Fixed in 71d65b0. A bare run id now expands every fold of that run, so the interrupt effect (and web's citation and interrupt paths) open all sections again. A single-fold run still uses the run id as its key. Collapsing a fold that's open because of the run id clears that id too, so the fold can always be closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm unable to act on this request because you do not have permissions within this repository.