Skip to content

fix(server): share MCP tool presentation across providers - #14313

Closed
Bil0000 wants to merge 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:t3code/cross-harness-mcp-reuse
Closed

Bil0000 wants to merge 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:t3code/cross-harness-mcp-reuse

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Includes #14277. One shared helper gives MCP tools readable names, supplied logos, and integration groups while preserving native tool data.

Verified with adapter tests, the Claude replay, server typecheck, targeted lint, and a fake-data UI check. Logos require provider metadata; Cursor and OpenCode currently use the default icon.

Before: raw MCP names

After: Firecrawl logos on the group and both tools

Model and harness: GPT-6.1 Sol via Codex in T3 Code.

scratchyone and others added 4 commits September 29, 2026 12:08
Claude Code sends each MCP tool's display name, server name and icon as
tool_use_meta on assistant frames. The Claude adapter now uses them for the
tool item's title and source, so rows read "Firecrawl scrape" with the
Firecrawl logo instead of mcp__claude_ai_Firecrawl__firecrawl_scrape.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 29, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes production MCP projection behavior across multiple provider adapters, including titles, integration grouping, icons, ACP identity recovery, and an OpenCode status lookup. Its tests are substantial, but the cross-provider runtime scope is broader than a small isolated presentation fix.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 1, 2026 — with ChatGPT Codex Connector
@juliusmarminge
juliusmarminge deleted the branch pingdotgg:t3code/codex-turn-mapping October 2, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants