Repository navigation
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This small bug-fix changes the shared WebSocket error contract and forwards raw provider or GitHub CLI causes to clients. Those causes may contain sensitive paths, account details, or credentials, warranting human security review. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
Fixed the blocking review finding at |
|
Note This comment is posted by Julius' dot The PR lists two regression suites but gives no executed results, and current-head CI is awaiting approval. The verification requirement requires observed outcomes for the changed behavior. Please run the focused error-serialization tests or link a completed CI run that includes them, then request reconsideration. |
Stacked on #13777. This resolves the remaining session-command error-surface review findings without changing Pi session behavior.
What changes
ProviderSessionCommandErrornow carries the bounded command category (copy|export|share) plus the underlying cause instead of copyingcause.messageinto the RPC-visible detail.Failed to share provider session.gh gist createstderr stays out ofPiRpcError.message; it is retained only as the underlying cause.Scope
No Pi turn/session lifecycle changes. No provider discovery or UI changes.
Validation
Focused regression coverage is included in:
apps/server/src/provider/PiSessionCommands.test.tsapps/server/src/server.test.tsThis branch is an exact stack on #13777 head
5f344199fbd5ace71194302362dcb5b96a829d8b; upstream CI is the executable validation surface.