Skip to content

perf(release): trim Windows packaging setup #14037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 2 commits into from
Oct 1, 2026
Merged

perf(release): trim Windows packaging setup #14037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee98a3
perf(release): trim Windows packaging setup
t3dotgg Sep 28, 2026
fa5a7e8
perf(release): skip the MSVC Spectre install when the monitor is cached
t3dotgg Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions .github/workflows/release-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ jobs:
# This repository is public, so Git needs no credentials. checkout's
# credential cleanup runs submodule foreach even with submodules disabled,
# which fails on the orphaned gitlinks in our vendored .repos tree.
# checkout.workers=0 writes the files on every core. Alternating both ways
# in one job on the Windows runners, it wrote the files about 10s faster
# (about 40% on arm64).
- name: Checkout
shell: bash
env:
Expand All @@ -120,28 +123,21 @@ jobs:
git remote add origin "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git"
git fetch --no-tags --depth=1 origin "$CHECKOUT_REF"
git sparse-checkout set --no-cone '/*' '!/.repos/'
git checkout --detach FETCH_HEAD

git -c checkout.workers=0 checkout --detach FETCH_HEAD

# Windows installs straight from the registry. There, linking the packages
# takes the time, not downloading them, so a ~700 MB package cache did not
# pay for its own restore. Across recent nightlies, restore plus install
# took 183-233s on arm64 and 116-172s on x64, while a plain install took
# 142-210s and 84-160s. The arm64 entries also filled 4 GB of the
# repository's 10 GB Actions cache.
- name: Setup Vite+
uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1
with:
node-version-file: package.json
cache: ${{ inputs.platform != 'win' }}
run-install: false

- name: Resolve Windows package cache path
if: inputs.platform == 'win'
id: package_cache_path
shell: pwsh
run: '"path=$(vp pm cache dir)" >> $env:GITHUB_OUTPUT'

- name: Cache Windows packages
if: inputs.platform == 'win'
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6
with:
path: ${{ steps.package_cache_path.outputs.path }}
key: windows-release-packages-v1-${{ inputs.arch }}-${{ hashFiles('pnpm-lock.yaml') }}

# pnpm checks the lockfile and policy before reusing this result. A missing
# artifact leaves the cache empty, so installation runs the checks again.
- name: Download dependency verification
Expand Down Expand Up @@ -217,8 +213,11 @@ jobs:
name: cli-linux-${{ inputs.arch }}
path: wsl-runtime

# Only the resource monitor build needs these libraries. With a cached
# monitor, the desktop build's preflight skips its MSVC check, and node-pty
# ships prebuilt Windows binaries, so the 30-60s install is skipped too.
- name: Install Spectre-mitigated MSVC libs
if: inputs.platform == 'win'
if: inputs.platform == 'win' && steps.resource_monitor_cache.outputs.cache-hit != 'true'
shell: pwsh
run: |
$vswhere = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"
Expand Down
Loading