Skip to content

fix(web): continue onboarding after incomplete history imports - #13935

Merged
maria-rcks merged 2 commits into
mainfrom
fix/onboarding-nonblocking-import
Sep 27, 2026
Merged

maria-rcks merged 2 commits into
mainfrom
fix/onboarding-nonblocking-import

Conversation

@t3-code

@t3-code t3-code Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

problem

A single failed history import leaves onboarding on the Projects step even when other threads imported successfully, as reported in https://x.com/emkara/status/2103985692032553420.

change

Finish setup after the import attempt, keep the existing landing-project selection, and show a persistent, dismissible warning after workspace navigation completes. Successful imports show an "Imported N threads" success toast after navigation; empty or skipped imports do not show success. Failure to save onboarding completion still keeps setup open, and retrying completion preserves the import warning.

Applies to the shared web/desktop onboarding wizard, including remote environments. No server, import protocol, provider adapter, or mobile changes.

verification

  • Regression reproduced before the fix: the actual wizard never completed with 28 imported threads and 1 skipped thread.
  • 29 focused tests pass, covering navigation ordering, partial/all-skipped/full/empty imports, completion-save retry, and existing project-selection behavior.
  • Web typecheck and formatting pass. Targeted lint reports existing warnings in the wizard; no errors.
  • Real Chromium app run against an isolated T3 home with 29 synthetic Claude transcripts: the real server imported 28 and rejected one invalid session ID. Before: remained in setup. After: navigated to a project draft and displayed the warning. No mocked import responses or real provider conversations.
  • Independent pre-commit reviewer unavailable locally; repository review pending.

before

setup requires another click after a partial import

after

workspace opens with a dismissible import warning

successful import

success notification after importing 28 fixture threads

transition recording

Real browser frames, captured with the synthetic transcript fixture described above.

https://t3bot-uploads-production.up.railway.app/files/tntwcyH19sZhUhihqx1f7m8J/onboarding-import-transition.mp4

request provenance

Requested by @extoci. Success notification requested by @UtkarshUsername.

Model: gpt-6-astra. Harness: Hermes Agent.

Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 27, 2026
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB −19 B (−0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB +5 B (+0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.5 KiB 6.4 KiB −24 B (−0.4%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.3 KiB 56.2 KiB −44 B (−0.1%) 66.4 KiB ✅
Codex Live turn messages 10 9 −1 (−10.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB +11 B (+0.1%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB +3 B (+0.0%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.4 KiB +8 B (+0.1%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: a727d1d · PR result: 63e764f · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 27, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 63e764f

Macroscope's review found this PR approvable — This is a focused onboarding bug fix that lets users continue after incomplete history imports while preserving the selected project and reporting partial results after navigation. It changes only two production files and adds targeted regression coverage, with no schema, server, security, deployment, default, or linting-impacting changes.

You can add or adjust custom eligibility rules. Learn more.

Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 27, 2026 08:21

Dismissing prior approval to re-evaluate 63e764f

@maria-rcks
maria-rcks merged commit de251fc into main Sep 27, 2026
24 of 25 checks passed
@maria-rcks
maria-rcks deleted the fix/onboarding-nonblocking-import branch September 27, 2026 09:54
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 27, 2026
## What's Changed
* test(relay): remove constant-restating database mode test by @t3-code[bot] in pingdotgg/t3code#13932
* fix(web): continue onboarding after incomplete history imports by @t3-code[bot] in pingdotgg/t3code#13935


**Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260927.2331...v0.0.43-nightly.20260927.2344

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260927.2344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant