Skip to content

fix(web): align reasoning arrows with tool calls - #13850

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
Adamulek123:fix/opencode-reasoning-arrow-alignment
Sep 26, 2026
Merged

juliusmarminge merged 1 commit into
pingdotgg:mainfrom
Adamulek123:fix/opencode-reasoning-arrow-alignment

Conversation

@Adamulek123

@Adamulek123 Adamulek123 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

Aligned the expand arrows on OpenCode reasoning rows with the arrows on adjacent tool-call rows. This adjusts the reasoning header's right padding without changing its expand behavior or the tool list's scrolling.

Why

When reasoning and tool calls appear together, the reasoning arrows sit farther right than the command arrows, making the list look uneven.

UI Changes

Before

image

After

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Validation: targeted format, lint, and web typecheck passed. In an isolated client preview of an OpenCode thread, reasoning and tool arrows aligned at the same right edge.

GPT-6-Astra via the Codex harness in T3 Code.

Summary by CodeRabbit

  • Style
    • Adjusted the reasoning disclosure header’s spacing, preserving its start inset while increasing the end inset.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 26, 2026
@Adamulek123
Adamulek123 marked this pull request as ready for review September 26, 2026 16:45
@macroscopeapp

macroscopeapp Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bb081dc

Macroscope's review found this PR approvable — This is a small, isolated styling fix that adjusts logical padding on an existing reasoning header to align it with tool calls. It does not alter behavior, data flow, product defaults, or static-analysis settings.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b3b27faa-0058-4555-bf04-5d3f48cf1c94

📥 Commits

Reviewing files that changed from the base of the PR and between 95030dc and bb081dc.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/MessagesTimeline.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The reasoning disclosure header keeps its start padding and increases its end padding.

Changes

Reasoning disclosure

Layer / File(s) Summary
Header padding
apps/web/src/components/chat/MessagesTimeline.tsx
The header changes from px-0.5 to ps-0.5 pe-2.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to bb081

The reasoning header spacing is adjusted to align its disclosure arrow; no material merge risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the focused UI fix: aligning reasoning arrows with tool-call arrows.
Description check ✅ Passed The description explains what changed, why it changed, and includes before/after screenshots for the UI change. It also reports validation results. No video is needed because the change does not modif…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit c9a0e8a into pingdotgg:main Sep 26, 2026
33 of 34 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 27, 2026
## What's Changed
* fix(clients): hide duplicate Cursor Keychain prompts by @Yash-Singh1 in pingdotgg/t3code#13870
* feat(observability): honor OTEL_*_EXPORTER=none per signal by @yordis in pingdotgg/t3code#13736
* fix(web): align reasoning arrows with tool calls by @Adamulek123 in pingdotgg/t3code#13850
* fix(server): let agents use simctl and adb alongside device tools by @juliusmarminge in pingdotgg/t3code#13908
* fix(web): environment status tooltip resizes when the status changes by @BearHuddleston in pingdotgg/t3code#13845

## New Contributors
* @BearHuddleston made their first contribution in pingdotgg/t3code#13845

**Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260926.2318...v0.0.43-nightly.20260927.2331

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260927.2331
juliusmarminge added a commit that referenced this pull request Sep 28, 2026
Conflicts resolved:
- CodexDeveloperInstructions: keep V2's launcher-path wording, take main's simctl/adb guidance.
- Cursor keychain timeout (#13870): V2 renamed cursorCredentialStore to cursorKeychainToken; point imports at the V2 file.
- ClaudeAdapter (V1, #13999): stays deleted on V2.
- MessagesTimeline (#13850): the reasoning header main restyled does not exist on V2.
- Sidebar: keep both new imports.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants