Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-file mobile fix restores compact Home-list trackpad scrolling by reusing the existing native-gesture composition already used by the sidebar and archive. Its runtime impact is limited to gesture arbitration between list scrolling and row swipes, with no changes to data, navigation, defaults, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate a225726
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughHomeScreen now registers a native gesture for the thread list, wraps LegendList in a GestureDetector, and passes the gesture to thread rows as their simultaneous swipe gesture. ChangesHome list gestures
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue remains in the reviewed change. Physical iPad and Magic Keyboard verification is still pending, but that alone does not establish a merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
a225726 to
1db8d92
Compare
What Changed
Register the compact Home thread list with a stable native scroll gesture and share it with the row swipeables. This matches the gesture composition already used by the wide iPad sidebar and Archive.
Fixes #13664.
Why
On the current App Store build, narrowing an iPad window to the iPhone-style Home list stops vertical Magic Keyboard trackpad scrolling. Direct touch scrolling still works, and horizontal row swipe input is still accepted. Expanding back to the wide sidebar restores trackpad scrolling.
Both routes render the same trackpad-enabled swipe rows, but Home omitted the
Gesture.Native()/GestureDetector/simultaneousSwipeGesturerelationship that lets native scrolling coexist with them. This adds that missing relationship without changing swipe thresholds, the existing scroll gate, row recycling, or navigation.Integrated
mainafter #13356 landed; its Android FAB clearance calculation is preserved. The PR diff remains confined to mobile Home. Web/desktop, providers, contracts, and connection modes are unaffected. iPhone external pointing-device behavior has not been reproduced.UI Changes
App Store reproduction video. Supplied by Alex, cropped to the React Native app and stripped of audio. The other app in the original recording was the SwiftUI rewrite, where scrolling works.
Compact Home before/after on the same iPhone 17 Pro simulator, using synthetic thread rows (the rendered layout is unchanged):
After: touch scrolling and row swipe reveal/close. This is simulator touch-input regression coverage, not a trackpad before/after comparison.
Verification
git diff --checkpassed.regular iOS snapshot node escaped its cumulative clip), so compact gesture regression coverage uses the iPhone running the same Home component.a225726) was installed and launched over USB on Alex’s physical iPad as T3 Code Preview. It bundles its JavaScript and has OTA updates disabled so the candidate stays pinned.Model: GPT-6 Astra | Harness: Codex in T3 Code