Skip to content

chore(web): keep the thread details split surface class module-private - #13570

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-thread-details-split
Sep 25, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-thread-details-split

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

vp run knip:check, the first step of CI's Check job, fails on the V2 branch tip:

Unused exports (1)
THREAD_DETAILS_PANEL_SPLIT_BUTTON_SURFACE_CLASS  apps/web/src/components/chat/threadDetailsPanelStyles.ts

99d76f2 added the constant as an export, but only other constants in the same module use it. This keeps it module-private.

Verification

  • vp run knip:check: clean (exit 0).
  • apps/web typecheck: no errors or warnings.

Model: Claude Opus 5.5 (Claude Code)

🤖 Generated with Claude Code


Devin Review

99d76f2 exported THREAD_DETAILS_PANEL_SPLIT_BUTTON_SURFACE_CLASS, but only
this module uses it, so knip fails the Check job on every PR against the V2
branch.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: c476160 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c476160

Macroscope's review found this PR approvable — This one-line change makes an unused styling constant module-private while preserving its value and all consuming class strings. It is a contained encapsulation cleanup with no product-default, runtime behavior, schema, deployment, or static-analysis suppression impact.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit e116684 into t3code/codex-turn-mapping Sep 25, 2026
24 of 25 checks passed
@juliusmarminge
juliusmarminge deleted the v2/knip-thread-details-split branch September 25, 2026 04:52
juliusmarminge added a commit that referenced this pull request Sep 25, 2026
#13570)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant