Skip to content

fix(codex): preserve native item start times - #13525

Merged
Yash-Singh1 merged 3 commits into
t3code/codex-turn-mappingfrom
t3code/351a24d5
Sep 25, 2026
Merged

Yash-Singh1 merged 3 commits into
t3code/codex-turn-mappingfrom
t3code/351a24d5

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

What Changed

Codex turn items now keep their own native start times instead of inheriting the turn start time. Subagent activity is grouped even when there is only one subagent, and collapsible panels animate consistently.

Why

Items within a Codex turn can start at different times. Using the turn start time made their timestamps inaccurate. Grouping single subagents also gives their expanded details the same disclosure behavior as larger groups.

UI Changes

No screenshots are needed. The change updates subagent grouping and disclosure behavior without changing the visible design.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

- Use Codex item start timestamps for turn items and execution nodes
- Assign first-seen times to items without a native start event
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 25, 2026
Comment thread apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.7 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: 07be58e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 07be58e

Macroscope's review found this PR approvable — The PR narrowly corrects Codex timeline timestamps by preserving native item start times, with a focused replay test covering command and compaction items. It does not alter provider execution, schemas, defaults, or deployment behavior.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 25, 2026
@Yash-Singh1
Yash-Singh1 merged commit e2d53ac into t3code/codex-turn-mapping Sep 25, 2026
24 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/351a24d5 branch September 25, 2026 00:32
@Yash-Singh1
Yash-Singh1 restored the t3code/351a24d5 branch September 25, 2026 00:32
juliusmarminge pushed a commit that referenced this pull request Sep 25, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant