Skip to content

fix(codex): replay legacy user-input requests as blocking #13509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Sep 24, 2026
Merged

fix(codex): replay legacy user-input requests as blocking #13509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/effect-codex-app-server/src/replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,18 @@ function normalizeLegacyInboundFrame(value: unknown): unknown {
}
normalized.params = params;
}
if (
normalized.method === "item/tool/requestUserInput" &&
typeof normalized.params === "object" &&
normalized.params !== null
) {
const params = { ...(normalized.params as Record<string, unknown>) };
// Codex treats a legacy request without `isBlocking` as blocking.
if (params.isBlocking === undefined) {

@macroscopeapp macroscopeapp Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes how replayed inbound requests are delivered, but the PR adds no focused test for it. Could you add a replay test with a legacy item/tool/requestUserInput frame that omits isBlocking, asserting the client receives true, and one with an explicit false to verify it remains unchanged?

Posted via Macroscope — Effect Service Conventions

params.isBlocking = true;
}
normalized.params = params;
}
return normalized;
}

Expand Down
Loading