Skip to content

chore(web): drop the right panel sheet class left unused by the V2 rebase - #13502

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-right-panel-sheet
Sep 24, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-right-panel-sheet

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

vp run knip:check, the first step of CI's Check job, fails on the V2 branch after the rebase onto main:

Unused exports (1)
RIGHT_PANEL_SHEET_CLASS_NAME  apps/web/src/rightPanelLayout.ts:2

Main deleted this constant in #13366 (80fc23a) when its last caller went away. The rebase kept the declaration but not the caller, so nothing imports it. This removes it the same way main did.

Verification

  • vp run knip:check: clean (exit 0).
  • apps/web typecheck: no errors or warnings.
  • git grep RIGHT_PANEL_SHEET_CLASS_NAME finds no other references.

Model: Claude Opus 5.5 (Claude Code)

🤖 Generated with Claude Code


Devin Review

…base

Main removed RIGHT_PANEL_SHEET_CLASS_NAME in #13366 when its last caller
went away. The rebase of the V2 branch kept the declaration, so knip fails
the Check job on every PR against the branch.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 24, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 4b7a277

Macroscope's review found this PR approvable — This PR removes an unused internal export from the web layout module, with no references remaining at the base or head and no resulting runtime behavior change. It does not alter product defaults or static-analysis suppression rules.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 28b15db into t3code/codex-turn-mapping Sep 24, 2026
22 of 24 checks passed
@juliusmarminge
juliusmarminge deleted the v2/knip-right-panel-sheet branch September 24, 2026 21:46
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
…base (#13502)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 25, 2026
…base (#13502)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant