Skip to content

chore(server): unexport OpenCode capabilities left unused by test removal - #13486

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-opencode-capabilities
Sep 24, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
v2/knip-opencode-capabilities

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

The Check job fails on every PR against t3code/codex-turn-mapping. Its first step, vp run knip:check, reports Unused exports (1): OpenCodeProviderCapabilitiesV2 apps/server/src/orchestration-v2/Adapters/OpenCodeAdapterV2.ts:149. #13459 removed the last test that imported that constant, and nothing outside OpenCodeAdapterV2.ts uses it now. Because knip fails first, the job stops before vp check and typecheck run, which hides any real failures from those steps.

Change

Drop export from OpenCodeProviderCapabilitiesV2. The constant is still used in the same file (getCapabilities and the session capabilities).

Verification

  • vp run knip:check on base tip 52c336a before the change: fails with the unused export above.
  • vp run knip:check after the change: exits 0 with no findings.
  • vp exec tsc --noEmit -p . in apps/server: exits 0, no error TS or warning TS lines.
  • vp lint and vp fmt --check on OpenCodeAdapterV2.ts: formatted. The one lint warning (an unused layer) was already there and is unrelated.
  • Not run: tests. The change only removes an export, and nothing imports the constant.

Model: Claude Opus 5.5 (Claude Code)

🤖 Generated with Claude Code


Devin Review

…oval

#13459 removed the last test importing OpenCodeProviderCapabilitiesV2,
so knip flags it as an unused export and fails the Check job on every
PR against this branch. It is only used inside OpenCodeAdapterV2.ts.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 24, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8c1dcde

Macroscope's review found this PR approvable — This is a one-line internal export cleanup; the capability object remains used by the adapter, with no change to runtime behavior, defaults, or production workflows. Repository searches found no remaining external consumers of the removed export.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.1 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 8c1dcde · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge merged commit f6da5af into t3code/codex-turn-mapping Sep 24, 2026
24 of 25 checks passed
@juliusmarminge
juliusmarminge deleted the v2/knip-opencode-capabilities branch September 24, 2026 20:27
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
…oval (#13486)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 24, 2026
…oval (#13486)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
juliusmarminge added a commit that referenced this pull request Sep 25, 2026
…oval (#13486)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant