Repository navigation
fix(antigravity): let Stop end commands that outlived their turn #13388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 5 commits into
main
from
t3code/antigravity-stop-background-commands
Sep 24, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cefab49
fix(antigravity): let Stop end commands that outlived their turn
juliusmarminge 4307381
fix(antigravity): decide idle Stop under the prompt lock
juliusmarminge 30dd7a6
fix(antigravity): finish an idle Stop even if its caller is interrupted
juliusmarminge 280994d
fix(antigravity): close an idle-stopped session in a finalizer
juliusmarminge 8167b0d
fix(antigravity): ignore stop failures in the idle-Stop finalizer
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 8920
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 42225
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 45547
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 4282
🌐 Web query:
Effect 4.0.0-rc.115 effect/Scope Scope.close API error interruption finalizer contract💡 Result:
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 43381
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 4078
Run session bookkeeping even when scope cleanup reports a failure.
If
Scope.close(context.scope, Exit.void)reports a finalizer failure,stopContextexits before it marks the context closed, removes it fromsessions, emitstask.completedfor promoted commands, or emitssession.exited. The runtime resources are owned bysessionScope, so this does not establish a live process leak, but the stopped context remains retained and its commands can remain stuck in the started state. Run the post-close bookkeeping in a guaranteed cleanup path while preserving the scope-close failure.🤖 Prompt for AI Agents